From 09cbd08c64d0f405ecfbafee7203ac4946ddac15 Mon Sep 17 00:00:00 2001 From: Jeff Wong Date: Tue, 8 Jan 2019 15:38:13 -0800 Subject: [PATCH] FIX: ensure ember transitions do not get hijacked by discourse intercept-click explicit null checks as a blank string evaluates to false --- app/assets/javascripts/discourse/lib/intercept-click.js.es6 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/lib/intercept-click.js.es6 b/app/assets/javascripts/discourse/lib/intercept-click.js.es6 index 1fe999912f..9d115ff9ab 100644 --- a/app/assets/javascripts/discourse/lib/intercept-click.js.es6 +++ b/app/assets/javascripts/discourse/lib/intercept-click.js.es6 @@ -27,9 +27,9 @@ export default function interceptClick(e) { !href || href === "#" || $currentTarget.attr("target") || - $currentTarget.data("ember-action") || - $currentTarget.data("auto-route") || - $currentTarget.data("share-url") || + $currentTarget.data("ember-action") != null || + $currentTarget.data("auto-route") != null || + $currentTarget.data("share-url") != null || $currentTarget.hasClass("widget-link") || $currentTarget.hasClass("raw-link") || $currentTarget.hasClass("mention") ||