FEATURE: backend support for user-selectable components

* FEATURE: backend support for user-selectable components

* fix problems with previewing default theme

* rename preview_key => preview_theme_id

* omit default theme from child themes dropdown and try a different fix

* cache & freeze stylesheets arrays

app/assets/javascripts/admin/controllers/admin-customize-themes-show.js.es6

@@ -1,4 +1,7 @@
-import { default as computed } from "ember-addons/ember-computed-decorators";
+import {
+  default as computed,
+  observes
+} from "ember-addons/ember-computed-decorators";
 import { url } from "discourse/lib/computed";
 import { popupAjaxError } from "discourse/lib/ajax-error";
 import showModal from "discourse/lib/show-modal";
@@ -9,6 +12,18 @@ const THEME_UPLOAD_VAR = 2;
 export default Ember.Controller.extend({
   editRouteName: "adminCustomizeThemes.edit",
 
+  @observes("allowChildThemes")
+  setSelectedThemeId() {
+    const available = this.get("selectableChildThemes");
+    if (
+      !this.get("selectedChildThemeId") &&
+      available &&
+      available.length > 0
+    ) {
+      this.set("selectedChildThemeId", available[0].get("id"));
+    }
+  },
+
   @computed("model", "allThemes")
   parentThemes(model, allThemes) {
     let parents = allThemes.filter(theme =>
@@ -64,16 +79,21 @@ export default Ember.Controller.extend({
 
     let themes = [];
     available.forEach(t => {
-      if (!childThemes || childThemes.indexOf(t) === -1) {
+      if (
+        (!childThemes || childThemes.indexOf(t) === -1) &&
+        Em.isEmpty(t.get("childThemes")) &&
+        !t.get("user_selectable") &&
+        !t.get("default")
+      ) {
         themes.push(t);
       }
     });
     return themes.length === 0 ? null : themes;
   },
 
-  @computed("allThemes", "allThemes.length", "model")
+  @computed("allThemes", "allThemes.length", "model", "parentThemes")
   availableChildThemes(allThemes, count) {
-    if (count === 1) {
+    if (count === 1 || this.get("parentThemes")) {
       return null;
     }
 

app/assets/javascripts/admin/models/theme.js.es6

@@ -1,5 +1,6 @@
 import RestModel from "discourse/models/rest";
 import { default as computed } from "ember-addons/ember-computed-decorators";
+import { popupAjaxError } from "discourse/lib/ajax-error";
 
 const THEME_UPLOAD_VAR = 2;
 
@@ -150,7 +151,9 @@ const Theme = RestModel.extend({
 
   saveChanges() {
     const hash = this.getProperties.apply(this, arguments);
-    return this.save(hash).then(() => this.set("changed", false));
+    return this.save(hash)
+      .finally(() => this.set("changed", false))
+      .catch(popupAjaxError);
   },
 
   saveSettings(name, value) {

app/assets/javascripts/admin/templates/customize-themes-show.hbs

@@ -137,7 +137,7 @@
     {{/unless}}
     {{#if selectableChildThemes}}
       <p>
-        {{combo-box content=selectableChildThemes value=selectedChildThemeId}}
+        {{combo-box filterable=true content=selectableChildThemes value=selectedChildThemeId}}
         {{#d-button action="addChildTheme" icon="plus"}}{{i18n "admin.customize.theme.add"}}{{/d-button}}
       </p>
     {{/if}}