From 0be6bcacee2c5a352a9a2daf02a7d5a5c58dbc77 Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 2 Jun 2014 10:56:16 +1000 Subject: [PATCH] PERF: optimise check --- app/assets/javascripts/discourse/models/post.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/models/post.js b/app/assets/javascripts/discourse/models/post.js index 40acf44a24..6463b90add 100644 --- a/app/assets/javascripts/discourse/models/post.js +++ b/app/assets/javascripts/discourse/models/post.js @@ -318,8 +318,8 @@ Discourse.Post = Discourse.Model.extend({ if (typeof value !== "function" && oldValue !== value) { // wishing for an identity map - if(key === "reply_to_user") { - skip = Em.get(value, "username") === Em.get(oldValue, "username"); + if(key === "reply_to_user" && value && oldValue) { + skip = value.username === oldValue.username || Em.get(value, "username") === Em.get(oldValue, "username"); } if(!skip) {