From 0c0192e7dabf6959c4248fa0454da206ac9c780f Mon Sep 17 00:00:00 2001
From: Sam Saffron <sam.saffron@gmail.com>
Date: Mon, 11 Nov 2019 16:04:18 +1100
Subject: [PATCH] DEV: disable all upload recovery specs

These specs are inherently fragile when they are run in a concurrent mode
in CI.

One process will create an upload, another will destroy the upload on disk
at the same time. We need a new safe mechanism here.
---
 spec/lib/upload_recovery_spec.rb | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/spec/lib/upload_recovery_spec.rb b/spec/lib/upload_recovery_spec.rb
index f248d009f5..3d8b840b1f 100644
--- a/spec/lib/upload_recovery_spec.rb
+++ b/spec/lib/upload_recovery_spec.rb
@@ -49,7 +49,7 @@ RSpec.describe UploadRecovery do
 
   describe '#recover' do
     describe 'when given an invalid sha1' do
-      it 'should not do anything' do
+      xit 'should not do anything' do
         upload_recovery.expects(:recover_from_local).never
 
         post.update!(
@@ -66,7 +66,7 @@ RSpec.describe UploadRecovery do
       end
     end
 
-    it 'accepts a custom ActiveRecord relation' do
+    xit 'accepts a custom ActiveRecord relation' do
       post.update!(updated_at: 2.days.ago)
       upload.destroy!
 
@@ -85,7 +85,7 @@ RSpec.describe UploadRecovery do
         ).tap(&:link_post_uploads)
       end
 
-      it 'should recover the attachment' do
+      xit 'should recover the attachment' do
         expect do
           upload2.destroy!
         end.to change { post.reload.uploads.count }.from(1).to(0)
@@ -99,7 +99,7 @@ RSpec.describe UploadRecovery do
       end
     end
 
-    it 'should recover uploads and attachments' do
+    xit 'should recover uploads and attachments' do
       stub_request(:get, "http://test.localhost#{upload.url}")
         .to_return(status: 200)
 
@@ -125,7 +125,7 @@ RSpec.describe UploadRecovery do
         ).tap(&:link_post_uploads)
       end
 
-      it 'should recover the upload' do
+      xit 'should recover the upload' do
         stub_request(:get, "http://test.localhost#{upload.url}")
           .to_return(status: 200)
 
@@ -152,7 +152,7 @@ RSpec.describe UploadRecovery do
         ).tap(&:link_post_uploads)
       end
 
-      it 'should recover the upload' do
+      xit 'should recover the upload' do
         stub_request(:get, "http://test.localhost#{upload.url}")
           .to_return(status: 200)
 
@@ -179,7 +179,7 @@ RSpec.describe UploadRecovery do
         ).tap(&:link_post_uploads)
       end
 
-      it 'should recover the upload' do
+      xit 'should recover the upload' do
         stub_request(:get, "http://test.localhost#{upload.url}")
           .to_return(status: 200)