From 16766a5d6204c3c19e7fa5a74812f308974f7d37 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Wed, 15 Jul 2020 13:10:05 -0400 Subject: [PATCH] FIX: `topic.details` is not a plain JS Object --- app/assets/javascripts/discourse/app/models/topic.js | 1 + .../components/select-kit/topic-notifications-button-test.js | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/models/topic.js b/app/assets/javascripts/discourse/app/models/topic.js index 98b0669f72..604fda2a6b 100644 --- a/app/assets/javascripts/discourse/app/models/topic.js +++ b/app/assets/javascripts/discourse/app/models/topic.js @@ -554,6 +554,7 @@ const Topic = RestModel.extend({ } } keys.forEach(key => this.set(key, json[key])); + return this; }, reload() { diff --git a/test/javascripts/components/select-kit/topic-notifications-button-test.js b/test/javascripts/components/select-kit/topic-notifications-button-test.js index 6f2f2861cc..fd23bdf792 100644 --- a/test/javascripts/components/select-kit/topic-notifications-button-test.js +++ b/test/javascripts/components/select-kit/topic-notifications-button-test.js @@ -5,7 +5,8 @@ import Topic from "discourse/models/topic"; const buildTopic = function(level, archetype = "regular") { return Topic.create({ - id: 4563, + id: 4563 + }).updateFromJson({ title: "Qunit Test Topic", details: { notification_level: level