From 1859e6b7ca1fabd7b11451eff40003db088b4ca3 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Fri, 20 Mar 2020 10:43:31 -0400 Subject: [PATCH] FIX: Don't fail if the test environment doesn't support Webauthn --- .../acceptance/preferences-test.js.es6 | 19 ++++++++++++------- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/test/javascripts/acceptance/preferences-test.js.es6 b/test/javascripts/acceptance/preferences-test.js.es6 index 66af8348ab..4e2f2d5979 100644 --- a/test/javascripts/acceptance/preferences-test.js.es6 +++ b/test/javascripts/acceptance/preferences-test.js.es6 @@ -256,14 +256,19 @@ QUnit.test("second factor security keys", async assert => { assert.ok(exists("#security-key-name"), "shows security key name input"); fillIn("#security-key-name", ""); - await click(".add-security-key"); - assert.ok( - find(".alert-error") - .html() - .indexOf("provide a name") > -1, - "shows name missing error message" - ); + // The following tests can only run when Webauthn is enabled. This is not + // always the case, for example on a browser running on a non-standard port + if (typeof PublicKeyCredential !== "undefined") { + await click(".add-security-key"); + + assert.ok( + find(".alert-error") + .html() + .indexOf("provide a name") > -1, + "shows name missing error message" + ); + } }); QUnit.test("default avatar selector", async assert => {