diff --git a/.rubocop.yml b/.rubocop.yml index 8472c89a91..e28a0876aa 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -102,6 +102,9 @@ Layout/EndAlignment: Lint/RequireParentheses: Enabled: true +Lint/ShadowingOuterLocalVariable: + Enabled: true + Layout/MultilineMethodCallIndentation: Enabled: true EnforcedStyle: indented diff --git a/Gemfile b/Gemfile index 2d077d6913..ca22ff21f3 100644 --- a/Gemfile +++ b/Gemfile @@ -34,7 +34,7 @@ gem 'redis-namespace' gem 'active_model_serializers', '~> 0.8.3' -gem 'onebox', '1.8.58' +gem 'onebox', '1.8.60' gem 'http_accept_language', '~>2.0.5', require: false @@ -193,3 +193,4 @@ if ENV["IMPORT"] == "1" end gem 'webpush', require: false +gem 'colored2', require: false diff --git a/Gemfile.lock b/Gemfile.lock index c6cb017879..689fe3d92d 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -257,7 +257,7 @@ GEM omniauth-twitter (1.4.0) omniauth-oauth (~> 1.1) rack - onebox (1.8.58) + onebox (1.8.60) htmlentities (~> 4.3) moneta (~> 1.0) multi_json (~> 1.11) @@ -458,6 +458,7 @@ DEPENDENCIES bullet byebug certified + colored2 cppjieba_rb danger discourse_image_optim @@ -509,7 +510,7 @@ DEPENDENCIES omniauth-oauth2 omniauth-openid omniauth-twitter - onebox (= 1.8.58) + onebox (= 1.8.60) openid-redis-store pg pry-nav diff --git a/app/assets/javascripts/admin/controllers/admin-dashboard-next-general.js.es6 b/app/assets/javascripts/admin/controllers/admin-dashboard-next-general.js.es6 index 84ad362327..2de7b16f16 100644 --- a/app/assets/javascripts/admin/controllers/admin-dashboard-next-general.js.es6 +++ b/app/assets/javascripts/admin/controllers/admin-dashboard-next-general.js.es6 @@ -23,11 +23,6 @@ export default Ember.Controller.extend(PeriodComputationMixin, { ), shouldDisplayDurability: Ember.computed.and("diskSpace"), - @computed - topReferredTopicsTopions() { - return { table: { total: false, limit: 8 } }; - }, - @computed activityMetrics() { return [ @@ -48,9 +43,38 @@ export default Ember.Controller.extend(PeriodComputationMixin, { }; }, + @computed + topReferredTopicsOptions() { + return { + table: { total: false, limit: 8 } + }; + }, + + @computed + topReferredTopicsFilters() { + return { + startDate: moment() + .subtract(6, "days") + .startOf("day"), + endDate: this.get("today") + }; + }, + + @computed + trendingSearchFilters() { + return { + startDate: moment() + .subtract(6, "days") + .startOf("day"), + endDate: this.get("today") + }; + }, + @computed trendingSearchOptions() { - return { table: { total: false, limit: 8 } }; + return { + table: { total: false, limit: 8 } + }; }, usersByTypeReport: staticReport("users_by_type"), diff --git a/app/assets/javascripts/admin/mixins/setting-component.js.es6 b/app/assets/javascripts/admin/mixins/setting-component.js.es6 index 9636c47732..532abe8f20 100644 --- a/app/assets/javascripts/admin/mixins/setting-component.js.es6 +++ b/app/assets/javascripts/admin/mixins/setting-component.js.es6 @@ -84,7 +84,7 @@ export default Ember.Mixin.create({ this.$().on("keydown.setting-enter", ".input-setting-string", function(e) { if (e.keyCode === 13) { // enter key - self._save(); + self.send("save"); } }); }.on("didInsertElement"), @@ -122,7 +122,7 @@ export default Ember.Mixin.create({ resetDefault() { this.set("buffered.value", this.get("setting.default")); - this._save(); + this.send("save"); }, toggleSecret() { diff --git a/app/assets/javascripts/admin/routes/admin-backups-index.js.es6 b/app/assets/javascripts/admin/routes/admin-backups-index.js.es6 index 760a102e28..39ed982a78 100644 --- a/app/assets/javascripts/admin/routes/admin-backups-index.js.es6 +++ b/app/assets/javascripts/admin/routes/admin-backups-index.js.es6 @@ -3,7 +3,7 @@ import Backup from "admin/models/backup"; export default Ember.Route.extend({ activate() { this.messageBus.subscribe("/admin/backups", backups => - this.controller.set("model", backups) + this.controller.set("model", backups.map(backup => Backup.create(backup))) ); }, diff --git a/app/assets/javascripts/admin/templates/backups.hbs b/app/assets/javascripts/admin/templates/backups.hbs index ac36550404..2dcd6e02ba 100644 --- a/app/assets/javascripts/admin/templates/backups.hbs +++ b/app/assets/javascripts/admin/templates/backups.hbs @@ -5,33 +5,31 @@ {{nav-item route='admin.backups.index' label='admin.backups.menu.backups'}} {{nav-item route='admin.backups.logs' label='admin.backups.menu.logs'}} {{plugin-outlet name="downloader" tagName=""}} -
- {{#if model.canRollback}} - {{d-button action="rollback" - class="btn-rollback" - label="admin.backups.operations.rollback.label" - title="admin.backups.operations.rollback.title" - icon="ambulance" - disabled=rollbackDisabled}} - {{/if}} - {{#if model.isOperationRunning}} - {{d-button action="cancelOperation" - class="btn-danger" - title="admin.backups.operations.cancel.title" - label="admin.backups.operations.cancel.label" - icon="times"}} - {{else}} - {{d-button action="startBackup" - class="btn-primary" - title="admin.backups.operations.backup.title" - label="admin.backups.operations.backup.label" - icon="rocket"}} - {{/if}} -
+
+ {{#if model.canRollback}} + {{d-button action="rollback" + class="btn-rollback" + label="admin.backups.operations.rollback.label" + title="admin.backups.operations.rollback.title" + icon="ambulance" + disabled=rollbackDisabled}} + {{/if}} + {{#if model.isOperationRunning}} + {{d-button action="cancelOperation" + class="btn-danger" + title="admin.backups.operations.cancel.title" + label="admin.backups.operations.cancel.label" + icon="times"}} + {{else}} + {{d-button action="startBackup" + class="btn-primary" + title="admin.backups.operations.backup.title" + label="admin.backups.operations.backup.label" + icon="rocket"}} + {{/if}} +
- -
diff --git a/app/assets/javascripts/admin/templates/components/flag-user.hbs b/app/assets/javascripts/admin/templates/components/flag-user.hbs index 92f6871847..26087789e5 100644 --- a/app/assets/javascripts/admin/templates/components/flag-user.hbs +++ b/app/assets/javascripts/admin/templates/components/flag-user.hbs @@ -7,7 +7,7 @@ {{#link-to 'adminUser' user.id user.username class="flag-user-username"}} {{user.username}} {{/link-to}} -
+
{{format-age date}}
diff --git a/app/assets/javascripts/admin/templates/components/site-setting.hbs b/app/assets/javascripts/admin/templates/components/site-setting.hbs index 03e5433fd0..558781c33d 100644 --- a/app/assets/javascripts/admin/templates/components/site-setting.hbs +++ b/app/assets/javascripts/admin/templates/components/site-setting.hbs @@ -13,5 +13,5 @@ {{#if setting.secret}} {{d-button action="toggleSecret" icon="eye-slash"}} {{/if}} - {{d-button action="resetDefault" icon="undo" label="admin.settings.reset"}} + {{d-button class="undo" action="resetDefault" icon="undo" label="admin.settings.reset"}} {{/if}} diff --git a/app/assets/javascripts/admin/templates/dashboard_next_general.hbs b/app/assets/javascripts/admin/templates/dashboard_next_general.hbs index c0ce8d74a1..98ca3f0304 100644 --- a/app/assets/javascripts/admin/templates/dashboard_next_general.hbs +++ b/app/assets/javascripts/admin/templates/dashboard_next_general.hbs @@ -154,12 +154,14 @@
{{admin-report + filters=topReferredTopicsFilters dataSourceName="top_referred_topics" - reportOptions=topReferredTopicsTopions}} + reportOptions=topReferredTopicsOptions}} {{admin-report dataSourceName="trending_search" reportOptions=trendingSearchOptions + filters=trendingSearchFilters isEnabled=logSearchQueriesEnabled disabledLabel="admin.dashboard.reports.trending_search.disabled"}} {{{i18n "admin.dashboard.reports.trending_search.more"}}} diff --git a/app/assets/javascripts/admin/templates/site-settings.hbs b/app/assets/javascripts/admin/templates/site-settings.hbs index 61e57209b7..8a1b8afcf3 100644 --- a/app/assets/javascripts/admin/templates/site-settings.hbs +++ b/app/assets/javascripts/admin/templates/site-settings.hbs @@ -1,9 +1,9 @@
- +
{{d-button action="toggleMenu" class="menu-toggle" icon="bars"}} - {{text-field value=filter placeholderKey="type_to_filter" class="no-blur"}} - {{d-button action="clearFilter" label="admin.site_settings.clear_filter"}} + {{text-field id="setting-filter" value=filter placeholderKey="type_to_filter" class="no-blur"}} + {{d-button id="clear-filter" action="clearFilter" label="admin.site_settings.clear_filter"}}