From 1c558d3ecc1bb443750d7d42aa9761ebecb77d5a Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Tue, 26 Nov 2019 15:49:58 +1000 Subject: [PATCH] FIX: oneboxer.js infinitely retrying failed requests (#8414) * setFailedCache was used like a variable object, when it was in fact a function --- app/assets/javascripts/pretty-text/oneboxer.js.es6 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/pretty-text/oneboxer.js.es6 b/app/assets/javascripts/pretty-text/oneboxer.js.es6 index cb7d94b641..034120502c 100644 --- a/app/assets/javascripts/pretty-text/oneboxer.js.es6 +++ b/app/assets/javascripts/pretty-text/oneboxer.js.es6 @@ -86,7 +86,7 @@ function loadNext(ajax) { removeLoading = false; loadingQueue.unshift({ url, refresh, $elem, categoryId, topicId }); } else { - setFailedCache[normalize(url)] = true; + setFailedCache(normalize(url), true); } } )