From 1dff3ad79dfeef25548e2c01079a3a50eeffd5a6 Mon Sep 17 00:00:00 2001
From: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Date: Mon, 25 Jul 2022 15:47:39 +0800
Subject: [PATCH] FIX: Title for keyboard shortcuts button in sidebar (#17638)

---
 .../discourse/app/templates/components/sidebar/footer.hbs | 2 +-
 .../discourse/tests/acceptance/sidebar-test.js            | 8 +++++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/templates/components/sidebar/footer.hbs b/app/assets/javascripts/discourse/app/templates/components/sidebar/footer.hbs
index 38fdaedb00..75ac740e7e 100644
--- a/app/assets/javascripts/discourse/app/templates/components/sidebar/footer.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/sidebar/footer.hbs
@@ -15,7 +15,7 @@
     <div class="sidebar-footer-actions">
       <DButton
         @action={{route-action "showKeyboardShortcutsHelp"}}
-        @title={{i18n "keyboard_shortcuts_help.title"}}
+        @title="keyboard_shortcuts_help.title"
         @icon="keyboard"
         @class="sidebar-footer-actions-button sidebar-footer-actions-keyboard-shortcuts" />
 
diff --git a/app/assets/javascripts/discourse/tests/acceptance/sidebar-test.js b/app/assets/javascripts/discourse/tests/acceptance/sidebar-test.js
index aebb1f1fe3..0648418d51 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/sidebar-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/sidebar-test.js
@@ -1,3 +1,5 @@
+import I18n from "I18n";
+
 import { test } from "qunit";
 import { click, currentRouteName, visit } from "@ember/test-helpers";
 import {
@@ -48,7 +50,11 @@ acceptance("Sidebar - User with sidebar enabled", function (needs) {
 
   test("viewing keyboard shortcuts using sidebar", async function (assert) {
     await visit("/");
-    await click(".sidebar-footer-actions-keyboard-shortcuts");
+    await click(
+      `.sidebar-footer-actions-keyboard-shortcuts[title="${I18n.t(
+        "keyboard_shortcuts_help.title"
+      )}"]`
+    );
 
     assert.ok(
       exists("#keyboard-shortcuts-help"),