From 284b9e9911ece8dc82e09b43a22e8ab0cf90c91f Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Mon, 31 Aug 2020 11:46:28 -0400 Subject: [PATCH] FIX: Flaky JS test due to not waiting for promises --- test/javascripts/models/post-test.js | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/test/javascripts/models/post-test.js b/test/javascripts/models/post-test.js index ad7fc393ec..63905f69ed 100644 --- a/test/javascripts/models/post-test.js +++ b/test/javascripts/models/post-test.js @@ -56,11 +56,11 @@ QUnit.test("updateFromPost", assert => { assert.equal(post.get("raw"), "different raw", "raw field updated"); }); -QUnit.test("destroy by staff", assert => { - var user = User.create({ username: "staff", moderator: true }), - post = buildPost({ user: user }); +QUnit.test("destroy by staff", async assert => { + let user = User.create({ username: "staff", moderator: true }); + let post = buildPost({ user: user }); - post.destroy(user); + await post.destroy(user); assert.present(post.get("deleted_at"), "it has a `deleted_at` field."); assert.equal( @@ -69,7 +69,8 @@ QUnit.test("destroy by staff", assert => { "it has the user in the `deleted_by` field" ); - post.recover(); + await post.recover(); + assert.blank( post.get("deleted_at"), "it clears `deleted_at` when recovering"