From 307c526840230daa0bc28d9b910dfe6487b7f44b Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Tue, 21 May 2019 12:57:14 +1000 Subject: [PATCH] DEV: correct test that assumed group 123 did not exist This is an incorrect assumption leading to a flaky test, cause for all we know, since sequences do not reset every test, group 123 could exist. --- spec/requests/admin/groups_controller_spec.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/requests/admin/groups_controller_spec.rb b/spec/requests/admin/groups_controller_spec.rb index fe0278cdd3..d641fb1d77 100644 --- a/spec/requests/admin/groups_controller_spec.rb +++ b/spec/requests/admin/groups_controller_spec.rb @@ -106,8 +106,8 @@ RSpec.describe Admin::GroupsController do context "#destroy" do it 'should return the right response for an invalid group_id' do - delete "/admin/groups/123.json" - + max_id = Group.maximum(:id).to_i + delete "/admin/groups/#{max_id + 1}.json" expect(response.status).to eq(404) end