DEV: enable frozen string literal on all files

This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging
This commit is contained in:
Sam Saffron
2019-05-03 08:17:27 +10:00
committed by Guo Xiang Tan
parent 4e1f25197d
commit 30990006a9
2201 changed files with 4482 additions and 90 deletions
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'mysql2'
module ImportScripts::PhpBB3
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require_relative 'database_base'
require_relative '../support/constants'
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require_relative 'database_3_0'
require_relative '../support/constants'
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class DatabaseBase
# @param database_client [Mysql2::Client]
+2
View File
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require_relative '../base'
require_relative 'support/settings'
require_relative 'database/database'
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class AttachmentImporter
# @param database [ImportScripts::PhpBB3::Database_3_0 | ImportScripts::PhpBB3::Database_3_1]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class AvatarImporter
# @param uploader [ImportScripts::Uploader]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class BookmarkImporter
def map_bookmark(row)
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class CategoryImporter
# @param lookup [ImportScripts::LookupContainer]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require_relative 'attachment_importer'
require_relative 'avatar_importer'
require_relative 'bookmark_importer'
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class MessageImporter
# @param database [ImportScripts::PhpBB3::Database_3_0 | ImportScripts::PhpBB3::Database_3_1]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class PermalinkImporter
CATEGORY_LINK_NORMALIZATION = '/(viewforum.php\?)(?:.*&)?(f=\d+).*/\1\2'
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class PollImporter
# @param lookup [ImportScripts::LookupContainer]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class PostImporter
# @param lookup [ImportScripts::LookupContainer]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require_relative '../support/constants'
module ImportScripts::PhpBB3
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class Constants
ACTIVE_USER = 0
@@ -1,3 +1,5 @@
# frozen_string_literal: true
require 'yaml'
module ImportScripts::PhpBB3
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class SmileyProcessor
# @param uploader [ImportScripts::Uploader]
@@ -1,3 +1,5 @@
# frozen_string_literal: true
module ImportScripts::PhpBB3
class TextProcessor
# @param lookup [ImportScripts::LookupContainer]