From 371bbadb92c02a43ae2ea362ead53cf6a4e575de Mon Sep 17 00:00:00 2001 From: Peter Wagenet Date: Tue, 5 Jul 2022 10:41:31 -0700 Subject: [PATCH] No implicit this codemod (#17235) * Run no-implicit-this codemod for app templates * Run tagless-ember-components-codemod for plugins * Turn on no-implicit-this lint --- .template-lintrc.js | 6 +- .../admin/addon/templates/admin.hbs | 14 +- .../admin/addon/templates/api-keys-index.hbs | 6 +- .../admin/addon/templates/api-keys-new.hbs | 24 +- .../admin/addon/templates/api-keys-show.hbs | 42 +-- .../admin/addon/templates/backups-index.hbs | 20 +- .../admin/addon/templates/backups-logs.hbs | 2 +- .../admin/addon/templates/backups.hbs | 6 +- .../admin/addon/templates/badges-award.hbs | 32 +- .../admin/addon/templates/badges-index.hbs | 4 +- .../admin/addon/templates/badges-show.hbs | 82 ++--- .../admin/addon/templates/badges.hbs | 4 +- .../addon/templates/components/ace-editor.hbs | 2 +- .../components/admin-backups-logs.hbs | 8 +- .../components/admin-editable-field.hbs | 10 +- .../templates/components/admin-form-row.hbs | 6 +- .../components/admin-penalty-history.hbs | 8 +- .../components/admin-report-counters.hbs | 24 +- .../components/admin-report-counts.hbs | 24 +- .../components/admin-report-inline-table.hbs | 2 +- .../admin-report-per-day-counts.hbs | 10 +- .../components/admin-report-storage-stats.hbs | 20 +- .../components/admin-report-table-cell.hbs | 2 +- .../components/admin-report-table-header.hbs | 10 +- .../components/admin-report-table-row.hbs | 4 +- .../components/admin-report-table.hbs | 28 +- .../admin-report-trust-level-counts.hbs | 12 +- .../templates/components/admin-report.hbs | 98 +++--- .../components/admin-theme-editor.hbs | 38 +-- .../components/admin-user-field-item.hbs | 36 +- .../components/admin-watched-word.hbs | 10 +- .../admin-web-hook-event-chooser.hbs | 6 +- .../components/admin-web-hook-event.hbs | 20 +- .../components/admin-web-hook-status.hbs | 2 +- .../components/dashboard-new-feature-item.hbs | 10 +- .../components/dashboard-new-features.hbs | 12 +- .../components/dashboard-problems.hbs | 14 +- .../components/email-styles-editor.hbs | 4 +- .../templates/components/embeddable-host.hbs | 22 +- .../components/embedding-setting.hbs | 12 +- .../templates/components/emoji-value-list.hbs | 12 +- .../templates/components/flag-user-lists.hbs | 6 +- .../addon/templates/components/flag-user.hbs | 12 +- .../templates/components/highlighted-code.hbs | 2 +- .../components/inline-edit-checkbox.hbs | 6 +- .../components/install-theme-item.hbs | 8 +- .../addon/templates/components/ip-lookup.hbs | 34 +- .../components/penalty-post-action.hbs | 6 +- .../templates/components/permalink-form.hbs | 8 +- .../components/report-filters/bool.hbs | 2 +- .../components/report-filters/category.hbs | 2 +- .../components/report-filters/group.hbs | 4 +- .../components/report-filters/list.hbs | 4 +- .../templates/components/resumable-upload.hbs | 6 +- .../components/screened-ip-address-form.hbs | 6 +- .../components/secret-value-list.hbs | 12 +- .../components/setting-validation-message.hbs | 4 +- .../templates/components/silence-details.hbs | 4 +- .../templates/components/simple-list.hbs | 10 +- .../site-customization-change-details.hbs | 22 +- .../site-customization-change-field.hbs | 6 +- .../templates/components/site-setting.hbs | 20 +- .../components/site-settings/bool.hbs | 6 +- .../site-settings/category-list.hbs | 6 +- .../components/site-settings/category.hbs | 8 +- .../components/site-settings/color.hbs | 6 +- .../components/site-settings/compact-list.hbs | 8 +- .../components/site-settings/emoji-list.hbs | 6 +- .../components/site-settings/enum.hbs | 10 +- .../components/site-settings/group-list.hbs | 6 +- .../components/site-settings/host-list.hbs | 8 +- .../components/site-settings/list.hbs | 6 +- .../components/site-settings/named-list.hbs | 8 +- .../components/site-settings/secret-list.hbs | 6 +- .../components/site-settings/simple-list.hbs | 6 +- .../components/site-settings/string.hbs | 16 +- .../components/site-settings/tag-list.hbs | 6 +- .../components/site-settings/upload.hbs | 6 +- .../site-settings/uploaded-image-list.hbs | 6 +- .../components/site-settings/url-list.hbs | 6 +- .../components/site-settings/value-list.hbs | 6 +- .../components/site-text-summary.hbs | 6 +- .../components/suspension-details.hbs | 10 +- .../templates/components/tags-uploader.hbs | 4 +- .../templates/components/themes-list-item.hbs | 24 +- .../templates/components/themes-list.hbs | 24 +- .../addon/templates/components/value-list.hbs | 10 +- .../templates/components/version-checks.hbs | 34 +- .../components/watched-word-form.hbs | 22 +- .../components/watched-word-uploader.hbs | 4 +- .../addon/templates/customize-colors-show.hbs | 32 +- .../addon/templates/customize-colors.hbs | 2 +- .../templates/customize-email-style-edit.hbs | 4 +- .../customize-email-templates-edit.hbs | 14 +- .../addon/templates/customize-robots-txt.hbs | 8 +- .../addon/templates/customize-themes-edit.hbs | 14 +- .../templates/customize-themes-index.hbs | 4 +- .../addon/templates/customize-themes-show.hbs | 160 ++++----- .../addon/templates/customize-themes.hbs | 4 +- .../admin/addon/templates/customize.hbs | 2 +- .../admin/addon/templates/dashboard.hbs | 12 +- .../addon/templates/dashboard_general.hbs | 44 +-- .../addon/templates/dashboard_moderation.hbs | 12 +- .../addon/templates/dashboard_reports.hbs | 4 +- .../addon/templates/dashboard_security.hbs | 4 +- .../addon/templates/email-advanced-test.hbs | 11 +- .../admin/addon/templates/email-bounced.hbs | 12 +- .../admin/addon/templates/email-index.hbs | 14 +- .../addon/templates/email-preview-digest.hbs | 26 +- .../admin/addon/templates/email-received.hbs | 10 +- .../admin/addon/templates/email-rejected.hbs | 12 +- .../admin/addon/templates/email-sent.hbs | 14 +- .../admin/addon/templates/email-skipped.hbs | 12 +- .../admin/addon/templates/embedding.hbs | 28 +- .../admin/addon/templates/emojis.hbs | 8 +- .../admin/addon/templates/logs.hbs | 2 +- .../addon/templates/logs/screened-emails.hbs | 6 +- .../templates/logs/screened-ip-addresses.hbs | 8 +- .../addon/templates/logs/screened-urls.hbs | 6 +- .../templates/logs/staff-action-logs.hbs | 28 +- .../templates/modal/admin-add-upload.hbs | 10 +- .../templates/modal/admin-api-key-urls.hbs | 2 +- .../templates/modal/admin-badge-preview.hbs | 18 +- .../modal/admin-color-scheme-select-base.hbs | 2 +- .../modal/admin-delete-posts-confirmation.hbs | 8 +- .../admin-delete-user-posts-progress.hbs | 2 +- .../modal/admin-edit-badge-groupings.hbs | 4 +- .../templates/modal/admin-incoming-email.hbs | 16 +- .../templates/modal/admin-install-theme.hbs | 55 ++-- .../modal/admin-merge-users-confirmation.hbs | 8 +- .../modal/admin-merge-users-progress.hbs | 2 +- .../modal/admin-merge-users-prompt.hbs | 8 +- .../addon/templates/modal/admin-reseed.hbs | 16 +- .../templates/modal/admin-silence-user.hbs | 20 +- .../modal/admin-staff-action-log-details.hbs | 2 +- .../templates/modal/admin-suspend-user.hbs | 22 +- .../templates/modal/admin-theme-change.hbs | 2 +- .../templates/modal/admin-theme-item.hbs | 10 +- .../modal/admin-uploaded-image-list.hbs | 4 +- .../modal/admin-watched-word-test.hbs | 16 +- .../modal/site-setting-default-categories.hbs | 4 +- .../admin/addon/templates/permalinks.hbs | 8 +- .../admin/addon/templates/plugins-index.hbs | 8 +- .../admin/addon/templates/plugins.hbs | 4 +- .../admin/addon/templates/reports-show.hbs | 2 +- .../addon/templates/search-logs-index.hbs | 12 +- .../addon/templates/search-logs-term.hbs | 18 +- .../templates/site-settings-category.hbs | 6 +- .../admin/addon/templates/site-settings.hbs | 6 +- .../admin/addon/templates/site-text-edit.hbs | 12 +- .../admin/addon/templates/site-text-index.hbs | 20 +- .../admin/addon/templates/user-badges.hbs | 14 +- .../admin/addon/templates/user-fields.hbs | 12 +- .../admin/addon/templates/user-index.hbs | 308 +++++++++--------- .../addon/templates/user-tl3-requirements.hbs | 100 +++--- .../admin/addon/templates/users-list-show.hbs | 38 +-- .../admin/addon/templates/users-list.hbs | 4 +- .../addon/templates/watched-words-action.hbs | 28 +- .../admin/addon/templates/watched-words.hbs | 4 +- .../addon/templates/web-hooks-show-events.hbs | 14 +- .../admin/addon/templates/web-hooks-show.hbs | 46 +-- .../admin/addon/templates/web-hooks.hbs | 8 +- .../discourse/app/templates/about.hbs | 68 ++-- .../templates/account-created/edit-email.hbs | 4 +- .../app/templates/account-created/index.hbs | 4 +- .../app/templates/account-created/resent.hbs | 4 +- .../discourse/app/templates/application.hbs | 18 +- .../discourse/app/templates/badges/index.hbs | 4 +- .../discourse/app/templates/badges/show.hbs | 32 +- .../discourse/app/templates/bulk-tag.hbs | 6 +- .../templates/components/about-page-users.hbs | 2 +- .../components/activation-controls.hbs | 8 +- .../components/activation-email-form.hbs | 2 +- .../templates/components/avatar-uploader.hbs | 10 +- .../app/templates/components/backup-codes.hbs | 6 +- .../app/templates/components/badge-button.hbs | 6 +- .../app/templates/components/badge-card.hbs | 22 +- .../templates/components/badge-selector.hbs | 2 +- .../app/templates/components/badge-title.hbs | 6 +- .../templates/components/basic-topic-list.hbs | 8 +- .../templates/components/bookmark-icon.hbs | 2 +- .../templates/components/bookmark-list.hbs | 16 +- .../app/templates/components/bookmark.hbs | 22 +- .../app/templates/components/bread-crumbs.hbs | 14 +- .../app/templates/components/cancel-link.hbs | 2 +- .../categories-and-latest-topics.hbs | 4 +- .../components/categories-and-top-topics.hbs | 4 +- .../components/categories-boxes-topic.hbs | 6 +- .../categories-boxes-with-topics.hbs | 6 +- .../templates/components/categories-boxes.hbs | 8 +- .../templates/components/categories-only.hbs | 28 +- .../components/categories-topic-list.hbs | 10 +- .../categories-with-featured-topics.hbs | 2 +- .../components/category-name-fields.hbs | 6 +- .../components/category-permission-row.hbs | 6 +- .../components/category-read-only-banner.hbs | 4 +- .../components/category-title-before.hbs | 2 +- .../components/category-title-link.hbs | 14 +- .../templates/components/category-unread.hbs | 8 +- .../app/templates/components/cdn-img.hbs | 6 +- .../templates/components/choose-message.hbs | 8 +- .../app/templates/components/choose-topic.hbs | 16 +- .../app/templates/components/color-input.hbs | 4 +- .../app/templates/components/color-picker.hbs | 4 +- .../components/composer-action-title.hbs | 4 +- .../templates/components/composer-editor.hbs | 4 +- .../components/composer-messages.hbs | 2 +- .../templates/components/composer-title.hbs | 4 +- .../templates/components/composer-toggles.hbs | 10 +- .../components/composer-user-selector.hbs | 6 +- .../conditional-loading-section.hbs | 6 +- .../conditional-loading-spinner.hbs | 4 +- .../app/templates/components/cook-text.hbs | 2 +- .../app/templates/components/copy-button.hbs | 2 +- .../app/templates/components/count-i18n.hbs | 2 +- .../components/create-invite-uploader.hbs | 10 +- .../components/create-topic-button.hbs | 4 +- .../components/create-topics-notice.hbs | 4 +- .../components/custom-html-container.hbs | 2 +- .../app/templates/components/d-button.hbs | 10 +- .../app/templates/components/d-editor.hbs | 26 +- .../templates/components/d-modal-cancel.hbs | 2 +- .../app/templates/components/d-modal.hbs | 20 +- .../components/d-navigation-item.hbs | 2 +- .../app/templates/components/d-navigation.hbs | 60 ++-- .../app/templates/components/d-popover.hbs | 4 +- .../app/templates/components/date-input.hbs | 4 +- .../app/templates/components/date-picker.hbs | 2 +- .../components/date-time-input-range.hbs | 4 +- .../templates/components/date-time-input.hbs | 14 +- .../desktop-notification-config.hbs | 6 +- .../templates/components/directory-item.hbs | 12 +- .../templates/components/directory-table.hbs | 12 +- .../templates/components/disabled-icon.hbs | 4 +- .../templates/components/discourse-banner.hbs | 12 +- .../components/discourse-linked-text.hbs | 2 +- .../components/discourse-tag-bound.hbs | 2 +- .../components/discovery-topics-list.hbs | 2 +- .../components/edit-category-general.hbs | 36 +- .../components/edit-category-images.hbs | 4 +- .../components/edit-category-panel.hbs | 2 +- .../components/edit-category-security.hbs | 20 +- .../components/edit-category-settings.hbs | 86 ++--- .../components/edit-category-tab.hbs | 2 +- .../components/edit-category-tags.hbs | 8 +- .../edit-category-topic-template.hbs | 2 +- .../components/edit-topic-timer-form.hbs | 24 +- .../components/emoji-group-buttons.hbs | 18 +- .../app/templates/components/emoji-picker.hbs | 20 +- .../templates/components/emoji-uploader.hbs | 8 +- .../app/templates/components/expand-post.hbs | 4 +- .../templates/components/featured-topic.hbs | 8 +- .../templates/components/flag-action-type.hbs | 30 +- .../templates/components/flag-selection.hbs | 2 +- .../app/templates/components/flat-button.hbs | 2 +- .../templates/components/footer-message.hbs | 4 +- .../components/future-date-input.hbs | 12 +- .../components/generated-invite-link.hbs | 6 +- .../templates/components/global-notice.hbs | 2 +- .../templates/components/google-search.hbs | 4 +- .../components/group-activity-filter.hbs | 4 +- .../components/group-card-contents.hbs | 30 +- .../components/group-flair-inputs.hbs | 26 +- .../components/group-imap-email-settings.hbs | 24 +- .../group-manage-email-settings.hbs | 18 +- .../components/group-manage-logs-filter.hbs | 4 +- .../components/group-manage-logs-row.hbs | 28 +- .../components/group-manage-save-button.hbs | 4 +- .../app/templates/components/group-member.hbs | 8 +- .../components/group-membership-button.hbs | 12 +- .../templates/components/group-navigation.hbs | 10 +- .../app/templates/components/group-post.hbs | 26 +- .../templates/components/group-selector.hbs | 2 +- .../components/group-smtp-email-settings.hbs | 24 +- .../groups-form-interaction-fields.hbs | 28 +- .../groups-form-membership-fields.hbs | 30 +- .../components/groups-form-profile-fields.hbs | 18 +- .../app/templates/components/groups-info.hbs | 6 +- .../templates/components/hidden-details.hbs | 8 +- .../components/ignored-user-list-item.hbs | 4 +- .../components/ignored-user-list.hbs | 2 +- .../templates/components/images-uploader.hbs | 10 +- .../app/templates/components/input-tip.hbs | 4 +- .../app/templates/components/invite-panel.hbs | 50 +-- .../app/templates/components/json-editor.hbs | 2 +- .../components/latest-topic-list-item.hbs | 22 +- .../templates/components/link-to-input.hbs | 10 +- .../templates/components/login-buttons.hbs | 4 +- .../components/mobile-category-topic.hbs | 10 +- .../app/templates/components/modal-panel.hbs | 2 +- .../app/templates/components/modal-tab.hbs | 2 +- .../app/templates/components/nav-item.hbs | 10 +- .../templates/components/navigation-bar.hbs | 6 +- .../templates/components/navigation-item.hbs | 8 +- .../notification-consent-banner.hbs | 2 +- .../components/parent-category-row.hbs | 38 +-- .../components/pick-files-button.hbs | 10 +- .../templates/components/plugin-outlet.hbs | 4 +- .../templates/components/popup-input-tip.hbs | 2 +- .../app/templates/components/popup-menu.hbs | 2 +- .../components/preference-checkbox.hbs | 4 +- .../components/private-message-glyph.hbs | 6 +- .../components/pwa-install-banner.hbs | 4 +- .../app/templates/components/quote-button.hbs | 19 +- .../templates/components/related-messages.hbs | 8 +- .../components/relative-time-picker.hbs | 4 +- .../components/reviewable-bundled-action.hbs | 14 +- .../components/reviewable-claimed-topic.hbs | 10 +- .../reviewable-conversation-post.hbs | 8 +- .../components/reviewable-created-by-name.hbs | 8 +- .../components/reviewable-created-by.hbs | 4 +- .../components/reviewable-field-category.hbs | 2 +- .../components/reviewable-field-editor.hbs | 2 +- .../components/reviewable-field-tags.hbs | 4 +- .../components/reviewable-field-text.hbs | 2 +- .../components/reviewable-field-textarea.hbs | 2 +- .../templates/components/reviewable-field.hbs | 8 +- .../components/reviewable-flagged-post.hbs | 14 +- .../components/reviewable-histories.hbs | 6 +- .../templates/components/reviewable-item.hbs | 58 ++-- .../components/reviewable-post-edits.hbs | 6 +- .../components/reviewable-post-header.hbs | 6 +- .../templates/components/reviewable-post.hbs | 12 +- .../components/reviewable-queued-post.hbs | 20 +- .../templates/components/reviewable-score.hbs | 40 +-- .../components/reviewable-scores.hbs | 6 +- .../templates/components/reviewable-tags.hbs | 4 +- .../components/reviewable-topic-link.hbs | 12 +- .../templates/components/reviewable-user.hbs | 22 +- .../templates/components/save-controls.hbs | 4 +- .../app/templates/components/score-value.hbs | 10 +- .../components/search-advanced-options.hbs | 46 +-- .../components/search-result-entries.hbs | 4 +- .../components/search-result-entry.hbs | 52 +-- .../components/second-factor-form.hbs | 12 +- .../components/second-factor-input.hbs | 2 +- .../components/security-key-form.hbs | 2 +- .../templates/components/selected-posts.hbs | 24 +- .../app/templates/components/share-panel.hbs | 8 +- .../app/templates/components/share-source.hbs | 2 +- .../components/shared-draft-controls.hbs | 6 +- .../app/templates/components/signup-cta.hbs | 2 +- .../templates/components/slow-mode-info.hbs | 6 +- .../components/software-update-prompt.hbs | 4 +- .../components/sub-category-item.hbs | 10 +- .../templates/components/sub-category-row.hbs | 18 +- .../subcategories-with-featured-topics.hbs | 2 +- .../templates/components/suggested-topics.hbs | 15 +- .../components/table-header-toggle.hbs | 6 +- .../templates/components/tag-drop-link.hbs | 2 +- .../templates/components/tag-groups-form.hbs | 22 +- .../app/templates/components/tag-info.hbs | 54 +-- .../app/templates/components/tag-list.hbs | 16 +- .../app/templates/components/tap-tile.hbs | 4 +- .../templates/components/text-overflow.hbs | 2 +- .../app/templates/components/time-input.hbs | 2 +- .../components/time-shortcut-picker.hbs | 10 +- .../components/top-period-buttons.hbs | 2 +- .../templates/components/topic-category.hbs | 14 +- .../components/topic-dismiss-buttons.hbs | 12 +- .../templates/components/topic-entrance.hbs | 4 +- .../components/topic-footer-buttons.hbs | 24 +- .../templates/components/topic-list-item.hbs | 2 +- .../app/templates/components/topic-list.hbs | 56 ++-- .../components/topic-navigation-popup.hbs | 2 +- .../templates/components/topic-navigation.hbs | 4 +- .../components/topic-post-badges.hbs | 8 +- .../templates/components/topic-progress.hbs | 12 +- .../app/templates/components/topic-status.hbs | 42 +-- .../templates/components/topic-timer-info.hbs | 14 +- .../app/templates/components/topic-title.hbs | 2 +- .../templates/components/track-selected.hbs | 2 +- .../components/uppy-backup-uploader.hbs | 6 +- .../components/uppy-image-uploader.hbs | 26 +- .../components/user-avatar-flair.hbs | 4 +- .../components/user-card-contents.hbs | 2 +- .../app/templates/components/user-info.hbs | 22 +- .../user-notification-schedule-day.hbs | 10 +- .../components/user-notification-schedule.hbs | 6 +- .../discourse/app/templates/composer.hbs | 146 ++++----- .../app/templates/composer/custom-body.hbs | 6 +- .../templates/composer/dominating-topic.hbs | 8 +- .../app/templates/composer/education.hbs | 4 +- .../app/templates/composer/get-a-room.hbs | 6 +- .../templates/composer/group-mentioned.hbs | 4 +- .../app/templates/composer/similar-topics.hbs | 4 +- .../discourse/app/templates/discovery.hbs | 14 +- .../app/templates/discovery/categories.hbs | 16 +- .../app/templates/discovery/topics.hbs | 46 +-- .../app/templates/edit-category-tabs.hbs | 46 +-- .../discourse/app/templates/email-login.hbs | 24 +- .../discourse/app/templates/exception.hbs | 14 +- .../app/templates/full-page-search.hbs | 94 +++--- .../app/templates/group-activity-posts.hbs | 6 +- .../app/templates/group-activity-topics.hbs | 4 +- .../discourse/app/templates/group-index.hbs | 42 +-- .../app/templates/group-requests.hbs | 14 +- .../discourse/app/templates/group.hbs | 32 +- .../app/templates/group/activity.hbs | 10 +- .../discourse/app/templates/group/manage.hbs | 4 +- .../app/templates/group/manage/categories.hbs | 12 +- .../app/templates/group/manage/email.hbs | 2 +- .../templates/group/manage/interaction.hbs | 4 +- .../app/templates/group/manage/logs.hbs | 16 +- .../app/templates/group/manage/membership.hbs | 4 +- .../app/templates/group/manage/profile.hbs | 4 +- .../app/templates/group/manage/tags.hbs | 14 +- .../app/templates/group/messages.hbs | 4 +- .../app/templates/group/permissions.hbs | 4 +- .../discourse/app/templates/groups/index.hbs | 14 +- .../discourse/app/templates/groups/new.hbs | 12 +- .../discourse/app/templates/invites/show.hbs | 78 ++--- .../mobile/components/categories-only.hbs | 22 +- .../categories-with-featured-topics.hbs | 2 +- .../mobile/components/directory-item.hbs | 16 +- .../mobile/components/mobile-nav.hbs | 6 +- .../mobile/components/navigation-bar.hbs | 10 +- .../mobile/components/parent-category-row.hbs | 40 +-- .../mobile/components/sub-category-item.hbs | 4 +- .../mobile/components/sub-category-row.hbs | 12 +- .../subcategories-with-featured-topics.hbs | 2 +- .../app/templates/mobile/discovery/topics.hbs | 32 +- .../app/templates/mobile/group-index.hbs | 18 +- .../app/templates/mobile/modal/login.hbs | 38 +-- .../discourse/app/templates/mobile/users.hbs | 28 +- .../discourse/app/templates/modal.hbs | 2 +- .../app/templates/modal/activation-edit.hbs | 4 +- .../app/templates/modal/activation-resent.hbs | 2 +- .../modal/associate-account-confirm.hbs | 20 +- .../app/templates/modal/auth-token.hbs | 16 +- .../app/templates/modal/avatar-selector.hbs | 42 +-- .../app/templates/modal/bookmark.hbs | 2 +- .../templates/modal/bulk-actions-buttons.hbs | 2 +- .../templates/modal/bulk-change-category.hbs | 4 +- .../modal/bulk-notification-level.hbs | 6 +- .../app/templates/modal/bulk-progress.hbs | 2 +- .../app/templates/modal/change-owner.hbs | 10 +- .../templates/modal/change-post-notice.hbs | 10 +- .../app/templates/modal/change-timestamp.hbs | 8 +- .../modal/convert-to-public-topic.hbs | 4 +- .../app/templates/modal/create-account.hbs | 92 +++--- .../templates/modal/create-invite-bulk.hbs | 2 +- .../app/templates/modal/create-invite.hbs | 54 +-- .../templates/modal/delete-topic-confirm.hbs | 4 +- .../app/templates/modal/discard-draft.hbs | 2 +- .../dismiss-notification-confirmation.hbs | 2 +- .../app/templates/modal/dismiss-read.hbs | 4 +- .../app/templates/modal/do-not-disturb.hbs | 2 +- .../app/templates/modal/download-calendar.hbs | 6 +- .../app/templates/modal/edit-slow-mode.hbs | 20 +- .../app/templates/modal/edit-topic-timer.hbs | 8 +- .../modal/edit-user-directory-columns.hbs | 6 +- .../templates/modal/explain-reviewable.hbs | 10 +- .../modal/feature-topic-on-profile.hbs | 4 +- .../app/templates/modal/feature-topic.hbs | 62 ++-- .../discourse/app/templates/modal/flag.hbs | 24 +- .../app/templates/modal/forgot-password.hbs | 16 +- .../app/templates/modal/fullscreen-code.hbs | 3 +- .../app/templates/modal/fullscreen-table.hbs | 2 +- .../app/templates/modal/grant-badge.hbs | 8 +- .../app/templates/modal/group-add-members.hbs | 16 +- .../modal/group-default-notifications.hbs | 2 +- .../discourse/app/templates/modal/history.hbs | 116 +++---- .../modal/ignore-duration-with-username.hbs | 8 +- .../app/templates/modal/ignore-duration.hbs | 6 +- .../app/templates/modal/insert-hyperlink.hbs | 10 +- .../app/templates/modal/jump-to-post.hbs | 6 +- .../modal/keyboard-shortcuts-help.hbs | 2 +- .../discourse/app/templates/modal/login.hbs | 46 +-- .../app/templates/modal/move-to-topic.hbs | 72 ++-- .../app/templates/modal/not-activated.hbs | 2 +- .../app/templates/modal/post-enqueued.hbs | 2 +- .../app/templates/modal/publish-page.hbs | 30 +- .../app/templates/modal/raw-email.hbs | 26 +- .../modal/reject-reason-reviewable.hbs | 4 +- .../templates/modal/reorder-categories.hbs | 2 +- .../modal/request-group-membership-form.hbs | 8 +- .../modal/second-factor-add-security-key.hbs | 10 +- .../modal/second-factor-add-totp.hbs | 16 +- .../modal/second-factor-backup-edit.hbs | 26 +- .../modal/second-factor-edit-security-key.hbs | 2 +- .../templates/modal/second-factor-edit.hbs | 2 +- .../app/templates/modal/share-and-invite.hbs | 2 +- .../app/templates/modal/share-topic.hbs | 16 +- .../templates/modal/topic-bulk-actions.hbs | 2 +- .../app/templates/modal/user-status.hbs | 18 +- .../app/templates/navigation/categories.hbs | 2 +- .../app/templates/navigation/category.hbs | 16 +- .../app/templates/navigation/default.hbs | 2 +- .../discourse/app/templates/outlet-list.hbs | 2 +- .../app/templates/password-reset.hbs | 34 +- .../app/templates/preferences-email.hbs | 18 +- .../templates/preferences-second-factor.hbs | 56 ++-- .../app/templates/preferences-username.hbs | 10 +- .../discourse/app/templates/preferences.hbs | 12 +- .../app/templates/preferences/account.hbs | 80 ++--- .../app/templates/preferences/apps.hbs | 6 +- .../app/templates/preferences/categories.hbs | 34 +- .../app/templates/preferences/emails.hbs | 46 +-- .../app/templates/preferences/interface.hbs | 74 ++--- .../templates/preferences/notifications.hbs | 24 +- .../app/templates/preferences/profile.hbs | 48 +-- .../app/templates/preferences/security.hbs | 24 +- .../app/templates/preferences/sidebar.hbs | 10 +- .../app/templates/preferences/tags.hbs | 16 +- .../app/templates/preferences/users.hbs | 18 +- .../discourse/app/templates/review-index.hbs | 32 +- .../app/templates/review-settings.hbs | 8 +- .../discourse/app/templates/review-show.hbs | 2 +- .../discourse/app/templates/review-topics.hbs | 4 +- .../discourse/app/templates/review.hbs | 2 +- .../app/templates/second-factor-auth.hbs | 26 +- .../app/templates/selected-posts.hbs | 2 +- .../discourse/app/templates/static.hbs | 12 +- .../app/templates/tag-groups-edit.hbs | 2 +- .../app/templates/tag-groups-index.hbs | 4 +- .../app/templates/tag-groups-new.hbs | 2 +- .../discourse/app/templates/tag-groups.hbs | 4 +- .../discourse/app/templates/tag/show.hbs | 42 +-- .../discourse/app/templates/tags/index.hbs | 24 +- .../discourse/app/templates/topic.hbs | 168 +++++----- .../discourse/app/templates/unknown.hbs | 2 +- .../discourse/app/templates/user-card.hbs | 6 +- .../app/templates/user-invited-show.hbs | 44 +-- .../discourse/app/templates/user-invited.hbs | 8 +- .../templates/user-private-messages-tags.hbs | 8 +- .../app/templates/user-topics-list.hbs | 18 +- .../discourse/app/templates/user.hbs | 182 +++++------ .../discourse/app/templates/user/activity.hbs | 16 +- .../discourse/app/templates/user/badges.hbs | 8 +- .../app/templates/user/bookmarks.hbs | 14 +- .../discourse/app/templates/user/messages.hbs | 52 +-- .../templates/user/notifications-index.hbs | 16 +- .../app/templates/user/notifications.hbs | 10 +- .../discourse/app/templates/user/posts.hbs | 2 +- .../discourse/app/templates/user/stream.hbs | 12 +- .../discourse/app/templates/user/summary.hbs | 68 ++-- .../discourse/app/templates/users.hbs | 30 +- .../category-drop/category-drop-header.hbs | 12 +- .../templates/components/category-row.hbs | 16 +- .../color-palettes/color-palettes-row.hbs | 8 +- .../components/combo-box/combo-box-header.hbs | 16 +- .../templates/components/create-color-row.hbs | 2 +- .../dropdown-select-box-header.hbs | 16 +- .../dropdown-select-box-row.hbs | 10 +- .../email-group-user-chooser-row.hbs | 18 +- .../addon/templates/components/flair-row.hbs | 6 +- .../future-date-input-selector-header.hbs | 18 +- .../future-date-input-selector-row.hbs | 10 +- .../mini-tag-chooser/selected-collection.hbs | 6 +- .../templates/components/multi-select.hbs | 48 +-- .../multi-select/format-selected-content.hbs | 2 +- .../multi-select/multi-select-header.hbs | 6 +- .../multi-select/selected-category.hbs | 4 +- .../notifications-filter-header.hbs | 4 +- .../period-chooser/period-chooser-header.hbs | 8 +- .../period-chooser/period-chooser-row.hbs | 4 +- .../templates/components/pinned-button.hbs | 4 +- .../select-kit/errors-collection.hbs | 4 +- .../components/select-kit/select-kit-body.hbs | 2 +- .../select-kit/select-kit-collection.hbs | 10 +- .../select-kit/select-kit-filter.hbs | 8 +- .../components/select-kit/select-kit-row.hbs | 6 +- .../select-kit/single-select-header.hbs | 8 +- .../components/selected-choice-category.hbs | 4 +- .../templates/components/selected-choice.hbs | 4 +- .../templates/components/selected-name.hbs | 20 +- .../templates/components/single-select.hbs | 40 +-- .../templates/components/tag-chooser-row.hbs | 2 +- .../tag-drop/more-tags-collection.hbs | 2 +- .../components/tag-drop/tag-drop-header.hbs | 12 +- .../addon/templates/components/tag-row.hbs | 4 +- .../toolbar-popup-menu-options-heading.hbs | 2 +- .../components/topic-notifications-button.hbs | 20 +- .../addon/templates/components/topic-row.hbs | 6 +- .../components/user-chooser/user-row.hbs | 8 +- .../templates/components/invite-list-user.hbs | 6 +- .../templates/components/invite-list.hbs | 12 +- .../templates/components/staff-count.hbs | 4 +- .../templates/components/styling-preview.hbs | 10 +- .../templates/components/theme-preview.hbs | 6 +- .../components/wizard-field-checkbox.hbs | 4 +- .../components/wizard-field-checkboxes.hbs | 4 +- .../components/wizard-field-dropdown.hbs | 8 +- .../components/wizard-field-image.hbs | 10 +- .../components/wizard-field-radio.hbs | 6 +- .../components/wizard-field-text.hbs | 2 +- .../components/wizard-field-textarea.hbs | 2 +- .../templates/components/wizard-field.hbs | 28 +- .../components/wizard-image-preview.hbs | 2 +- .../templates/components/wizard-step.hbs | 46 +-- .../wizard/addon/templates/step.hbs | 2 +- .../wizard/addon/templates/wizard.hbs | 4 +- .../discourse-local-dates-create-form.hbs | 66 ++-- .../discourse-local-dates-create-modal.hbs | 2 +- .../components/composer-presence-display.hbs | 10 +- .../components/topic-presence-display.hbs | 6 +- .../before-composer-controls/presence.hbs | 2 +- .../topic-above-footer-buttons/presence.hbs | 2 +- .../components/poll-breakdown-option.hbs | 2 +- .../templates/modal/poll-ui-builder.hbs | 71 ++-- .../templates/components/color-example.hbs | 4 +- .../components/styleguide-example.hbs | 2 +- .../templates/components/styleguide-icons.hbs | 2 +- .../templates/components/styleguide-link.hbs | 4 +- .../components/styleguide-section.hbs | 6 +- .../discourse/templates/styleguide.hbs | 2 +- .../templates/styleguide/atoms/02-buttons.hbs | 24 +- .../styleguide/atoms/05-input-fields.hbs | 10 +- .../templates/styleguide/atoms/dropdowns.hbs | 42 +-- .../templates/styleguide/atoms/topic-link.hbs | 2 +- .../styleguide/atoms/topic-statuses.hbs | 14 +- .../styleguide/molecules/bread-crumbs.hbs | 6 +- .../styleguide/molecules/categories.hbs | 8 +- .../styleguide/molecules/empty-state.hbs | 2 +- .../styleguide/molecules/footer-message.hbs | 6 +- .../styleguide/molecules/header-icons.hbs | 4 +- .../styleguide/molecules/navigation-bar.hbs | 8 +- .../molecules/navigation-stacked.hbs | 4 +- .../styleguide/molecules/post-menu.hbs | 2 +- .../styleguide/molecules/topic-list-item.hbs | 8 +- .../molecules/topic-notifications.hbs | 2 +- .../styleguide/molecules/topic-timer-info.hbs | 2 +- .../styleguide/organisms/00-post.hbs | 2 +- .../styleguide/organisms/01-topic-map.hbs | 2 +- .../organisms/03-topic-footer-buttons.hbs | 2 +- .../styleguide/organisms/04-topic-list.hbs | 4 +- .../styleguide/organisms/basic-topic-list.hbs | 2 +- .../styleguide/organisms/categories-list.hbs | 2 +- .../templates/styleguide/organisms/modal.hbs | 2 +- .../styleguide/organisms/navigation.hbs | 4 +- .../styleguide/organisms/site-header.hbs | 4 +- .../styleguide/organisms/suggested-topics.hbs | 2 +- .../styleguide/organisms/user-about.hbs | 124 +++---- .../discourse/templates/styleguide/show.hbs | 6 +- 635 files changed, 4626 insertions(+), 4634 deletions(-) diff --git a/.template-lintrc.js b/.template-lintrc.js index 955a8d36d6..604f813f52 100644 --- a/.template-lintrc.js +++ b/.template-lintrc.js @@ -19,7 +19,11 @@ module.exports = { "no-inline-styles": false, "no-input-block": true, "no-input-tagname": true, - "no-implicit-this": false, + "no-implicit-this": { + allow: [ + 'loading-spinner' + ] + }, "no-invalid-interactive": true, "no-invalid-link-text": true, "no-invalid-meta": true, diff --git a/app/assets/javascripts/admin/addon/templates/admin.hbs b/app/assets/javascripts/admin/addon/templates/admin.hbs index cdfe169291..7392a53d3c 100644 --- a/app/assets/javascripts/admin/addon/templates/admin.hbs +++ b/app/assets/javascripts/admin/addon/templates/admin.hbs @@ -4,24 +4,24 @@
-
+
{{outlet}}
diff --git a/app/assets/javascripts/admin/addon/templates/api-keys-index.hbs b/app/assets/javascripts/admin/addon/templates/api-keys-index.hbs index 24816b5d8d..c99261ad94 100644 --- a/app/assets/javascripts/admin/addon/templates/api-keys-index.hbs +++ b/app/assets/javascripts/admin/addon/templates/api-keys-index.hbs @@ -1,6 +1,6 @@ -{{#if model}} +{{#if this.model}} @@ -12,7 +12,7 @@ - {{#each model as |k|}} + {{#each this.model as |k|}}
 
{{#if k.revoked_at}}{{d-icon "times-circle"}}{{/if}} @@ -57,7 +57,7 @@
- + {{else}}

{{i18n "admin.api.none"}}

{{/if}} diff --git a/app/assets/javascripts/admin/addon/templates/api-keys-new.hbs b/app/assets/javascripts/admin/addon/templates/api-keys-new.hbs index d8dc05558e..3c9c5310d0 100644 --- a/app/assets/javascripts/admin/addon/templates/api-keys-new.hbs +++ b/app/assets/javascripts/admin/addon/templates/api-keys-new.hbs @@ -4,9 +4,9 @@
- {{#if model.id}} + {{#if this.model.id}} -
{{model.key}}
+
{{this.model.key}}
 {{i18n "admin.api.not_shown_again"}} @@ -16,16 +16,16 @@ {{else}} - + - + - {{#if showUserSelector}} + {{#if this.showUserSelector}} - @@ -33,16 +33,16 @@ {{/if}} - + - {{#if (eq scopeMode "read_only")}} + {{#if (eq this.scopeMode "read_only")}}

{{i18n "admin.api.scopes.descriptions.global.read"}}

- {{else if (eq scopeMode "global")}} + {{else if (eq this.scopeMode "global")}}

{{i18n "admin.api.scopes.global_description"}}

{{/if}} - {{#if (eq scopeMode "granular")}} + {{#if (eq this.scopeMode "granular")}}

{{i18n "admin.api.scopes.title"}}

{{i18n "admin.api.scopes.description"}}

@@ -55,7 +55,7 @@ - {{#each-in scopes as |resource actions|}} + {{#each-in this.scopes as |resource actions|}} @@ -86,6 +86,6 @@
{{resource}}
{{/if}} - + {{/if}}
diff --git a/app/assets/javascripts/admin/addon/templates/api-keys-show.hbs b/app/assets/javascripts/admin/addon/templates/api-keys-show.hbs index 5707d4cf3e..43ae76c3ce 100644 --- a/app/assets/javascripts/admin/addon/templates/api-keys-show.hbs +++ b/app/assets/javascripts/admin/addon/templates/api-keys-show.hbs @@ -5,21 +5,21 @@
- {{#if model.revoked_at}}{{d-icon "times-circle"}}{{/if}} - {{model.truncatedKey}} + {{#if this.model.revoked_at}}{{d-icon "times-circle"}}{{/if}} + {{this.model.truncatedKey}} - {{#if editingDescription}} - + {{#if this.editingDescription}} + {{else}} - {{if model.description model.description (i18n "admin.api.no_description")}} + {{if this.model.description this.model.description (i18n "admin.api.no_description")}} {{/if}}
- {{#if editingDescription}} + {{#if this.editingDescription}} {{else}} @@ -29,9 +29,9 @@ - {{#if model.user}} - - {{avatar model.user imageSize="small"}} {{model.user.username}} + {{#if this.model.user}} + + {{avatar this.model.user imageSize="small"}} {{this.model.user.username}} {{else}} {{i18n "admin.api.all_users"}} @@ -39,38 +39,38 @@ - {{format-date model.created_at leaveAgo="true"}} + {{format-date this.model.created_at leaveAgo="true"}} - {{format-date model.updated_at leaveAgo="true"}} + {{format-date this.model.updated_at leaveAgo="true"}} - {{#if model.last_used_at}} - {{format-date model.last_used_at leaveAgo="true"}} + {{#if this.model.last_used_at}} + {{format-date this.model.last_used_at leaveAgo="true"}} {{else}} {{i18n "admin.api.never_used"}} {{/if}} - {{#if model.revoked_at}} - {{format-date model.revoked_at leaveAgo="true"}} + {{#if this.model.revoked_at}} + {{format-date this.model.revoked_at leaveAgo="true"}} {{else}} {{i18n "no_value"}} {{/if}}
- {{#if model.revoked_at}} - - + {{#if this.model.revoked_at}} + + {{else}} - + {{/if}}
- {{#if model.api_key_scopes.length}} + {{#if this.model.api_key_scopes.length}}

{{i18n "admin.api.scopes.title"}}

@@ -83,7 +83,7 @@ - {{#each model.api_key_scopes as |scope|}} + {{#each this.model.api_key_scopes as |scope|}} - {{#each model as |backup|}} + {{#each this.model as |backup|}} diff --git a/app/assets/javascripts/admin/addon/templates/backups-logs.hbs b/app/assets/javascripts/admin/addon/templates/backups-logs.hbs index 1f4a77418d..88ee8f9ec5 100644 --- a/app/assets/javascripts/admin/addon/templates/backups-logs.hbs +++ b/app/assets/javascripts/admin/addon/templates/backups-logs.hbs @@ -1 +1 @@ - + diff --git a/app/assets/javascripts/admin/addon/templates/backups.hbs b/app/assets/javascripts/admin/addon/templates/backups.hbs index ca33af1c50..baeed29748 100644 --- a/app/assets/javascripts/admin/addon/templates/backups.hbs +++ b/app/assets/javascripts/admin/addon/templates/backups.hbs @@ -6,10 +6,10 @@
- {{#if model.canRollback}} - + {{#if this.model.canRollback}} + {{/if}} - {{#if model.isOperationRunning}} + {{#if this.model.isOperationRunning}} {{else}} diff --git a/app/assets/javascripts/admin/addon/templates/badges-award.hbs b/app/assets/javascripts/admin/addon/templates/badges-award.hbs index b91297be45..a18133d2ec 100644 --- a/app/assets/javascripts/admin/addon/templates/badges-award.hbs +++ b/app/assets/javascripts/admin/addon/templates/badges-award.hbs @@ -2,12 +2,12 @@

{{i18n "admin.badges.mass_award.title"}}

{{i18n "admin.badges.mass_award.description"}}

- {{#if model}} + {{#if this.model}}
- {{#if model}} - {{icon-or-image model}} - {{model.name}} + {{#if this.model}} + {{icon-or-image this.model}} + {{this.model.name}} {{else}} {{i18n "admin.badges.mass_award.no_badge_selected"}} {{/if}} @@ -18,47 +18,47 @@
- {{#if model.multiple_grant}} + {{#if this.model.multiple_grant}} {{/if}}
- + {{d-icon "times"}} {{i18n "cancel"}} - {{#if saving}} + {{#if this.saving}} {{i18n "uploading"}} {{/if}} - {{#if resultsMessage}} + {{#if this.resultsMessage}}

- {{#if success}} + {{#if this.success}} {{d-icon "check" class="bulk-award-status-icon success"}} {{else}} {{d-icon "times" class="bulk-award-status-icon failure"}} {{/if}} - {{resultsMessage}} + {{this.resultsMessage}}

- {{#if unmatchedEntries.length}} + {{#if this.unmatchedEntries.length}}

{{d-icon "exclamation-triangle" class="bulk-award-status-icon failure"}} - {{#if unmatchedEntriesTruncated}} - {{i18n "admin.badges.mass_award.csv_has_unmatched_users_truncated_list" count=unmatchedEntriesCount}} + {{#if this.unmatchedEntriesTruncated}} + {{i18n "admin.badges.mass_award.csv_has_unmatched_users_truncated_list" count=this.unmatchedEntriesCount}} {{else}} {{i18n "admin.badges.mass_award.csv_has_unmatched_users"}} {{/if}}

    - {{#each unmatchedEntries as |entry|}} + {{#each this.unmatchedEntries as |entry|}}
  • {{entry}}
    • {{/each}}
diff --git a/app/assets/javascripts/admin/addon/templates/badges-index.hbs b/app/assets/javascripts/admin/addon/templates/badges-index.hbs index 240428ab45..9e2b04e2a0 100644 --- a/app/assets/javascripts/admin/addon/templates/badges-index.hbs +++ b/app/assets/javascripts/admin/addon/templates/badges-index.hbs @@ -1,10 +1,10 @@
- {{i18n + {{i18n

{{i18n "admin.badges.badge_intro.title"}}

- {{#each badgeIntroLinks as |link|}} + {{#each this.badgeIntroLinks as |link|}} {{d-icon link.icon}} {{i18n link.text}} diff --git a/app/assets/javascripts/admin/addon/templates/badges-show.hbs b/app/assets/javascripts/admin/addon/templates/badges-show.hbs index 75e1803afd..60948580a6 100644 --- a/app/assets/javascripts/admin/addon/templates/badges-show.hbs +++ b/app/assets/javascripts/admin/addon/templates/badges-show.hbs @@ -2,15 +2,15 @@
- {{#if readOnly}} - + {{#if this.readOnly}} +

- + {{i18n "admin.badges.read_only_setting_help"}}

{{else}} - + {{/if}}
@@ -18,29 +18,29 @@
- {{#if imageUploaderSelected}} - + {{#if this.imageUploaderSelected}} +

{{i18n "admin.badges.image_help"}}

- {{else if iconSelectorSelected}} - + {{else if this.iconSelectorSelected}} + {{/if}}
-
@@ -48,71 +48,71 @@
- +
- {{#if buffered.system}} - + - + href="data:application/octet-stream;charset=utf-8;base64,{{this.base64BackupCode}}"> {{d-icon "download"}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/badge-button.hbs b/app/assets/javascripts/discourse/app/templates/components/badge-button.hbs index 2af01ef27e..a6ece24e8b 100644 --- a/app/assets/javascripts/discourse/app/templates/components/badge-button.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/badge-button.hbs @@ -1,5 +1,5 @@ - - {{icon-or-image badge}} - {{badge.name}} + + {{icon-or-image this.badge}} + {{this.badge.name}} {{yield}} diff --git a/app/assets/javascripts/discourse/app/templates/components/badge-card.hbs b/app/assets/javascripts/discourse/app/templates/components/badge-card.hbs index 58c279989d..c51e4641b4 100644 --- a/app/assets/javascripts/discourse/app/templates/components/badge-card.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/badge-card.hbs @@ -1,24 +1,24 @@ -{{#if displayCount}} - {{displayCount}} +{{#if this.displayCount}} + {{this.displayCount}} {{/if}} -{{#if badge.has_badge}} - {{d-icon "check"}} +{{#if this.badge.has_badge}} + {{d-icon "check"}} {{/if}} -{{#if canFavorite}} - {{#if isFavorite}} - +{{#if this.canFavorite}} + {{#if this.isFavorite}} + {{else}} - + {{/if}} {{/if}}
- {{icon-or-image badge}} + {{icon-or-image this.badge}}
-

{{badge.name}}

-
{{html-safe summary}}
+

{{this.badge.name}}

+
{{html-safe this.summary}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/badge-selector.hbs b/app/assets/javascripts/discourse/app/templates/components/badge-selector.hbs index 5ea3c796ec..495b23d6c3 100644 --- a/app/assets/javascripts/discourse/app/templates/components/badge-selector.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/badge-selector.hbs @@ -1 +1 @@ - + diff --git a/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs b/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs index d32973e1dd..0df8660129 100644 --- a/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/badge-title.hbs @@ -9,14 +9,14 @@
- +
- - {{#if _isSaved}} + + {{#if this._isSaved}} {{i18n "saved"}} {{/if}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/basic-topic-list.hbs b/app/assets/javascripts/discourse/app/templates/components/basic-topic-list.hbs index 87f36da385..38c2505af4 100644 --- a/app/assets/javascripts/discourse/app/templates/components/basic-topic-list.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/basic-topic-list.hbs @@ -1,8 +1,8 @@ - - {{#if topics}} - + + {{#if this.topics}} + {{else}} - {{#unless loadingMore}} + {{#unless this.loadingMore}}
{{i18n "choose_topic.none_found"}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/bookmark-icon.hbs b/app/assets/javascripts/discourse/app/templates/components/bookmark-icon.hbs index 6d82c0977d..0058894226 100644 --- a/app/assets/javascripts/discourse/app/templates/components/bookmark-icon.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/bookmark-icon.hbs @@ -1 +1 @@ -{{d-icon icon translatedTitle=title class=cssClasses}} +{{d-icon this.icon translatedTitle=this.title class=this.cssClasses}} diff --git a/app/assets/javascripts/discourse/app/templates/components/bookmark-list.hbs b/app/assets/javascripts/discourse/app/templates/components/bookmark-list.hbs index 7f1daf3065..586e1801db 100644 --- a/app/assets/javascripts/discourse/app/templates/components/bookmark-list.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/bookmark-list.hbs @@ -1,8 +1,8 @@ - - + +
{{scope.resource}} diff --git a/app/assets/javascripts/admin/addon/templates/backups-index.hbs b/app/assets/javascripts/admin/addon/templates/backups-index.hbs index 732b8f308b..1261659a46 100644 --- a/app/assets/javascripts/admin/addon/templates/backups-index.hbs +++ b/app/assets/javascripts/admin/addon/templates/backups-index.hbs @@ -1,17 +1,17 @@
- {{#if localBackupStorage}} - + {{#if this.localBackupStorage}} + {{else}} {{/if}} - {{#if site.isReadOnly}} - + {{#if this.site.isReadOnly}} + {{else}} - + {{/if}}
- {{#if status.restoreDisabled}} + {{#if this.status.restoreDisabled}} {{d-icon "info-circle"}} {{i18n "admin.backups.operations.restore.is_disabled"}} {{/if}}
@@ -23,19 +23,19 @@
{{backup.filename}} {{human-size backup.size}}
- {{#if status.isOperationRunning}} + {{#if this.status.isOperationRunning}} - + {{else}} - + {{/if}}
- {{#unless site.mobileView}} + {{#unless this.site.mobileView}} @@ -11,7 +11,7 @@ {{/unless}} - {{#each content as |bookmark|}} + {{#each this.content as |bookmark|}} - {{#unless site.mobileView}} + {{#unless this.site.mobileView}}
{{i18n "topic.title"}}   {{i18n "post.bookmarks.updated"}}
@@ -48,10 +48,10 @@ {{#if bookmark.bookmarkableTopicAlike}}
{{category-link bookmark.category}} - {{discourse-tags bookmark mode="list" tagsForUser=tagsForUser}} + {{discourse-tags bookmark mode="list" tagsForUser=this.tagsForUser}}
{{/if}} - {{#if (and site.mobileView bookmark.excerpt bookmark.user.avatar_template)}} + {{#if (and this.site.mobileView bookmark.excerpt bookmark.user.avatar_template)}} {{avatar bookmark.bookmarkableUser avatarTemplatePath="avatar_template" usernamePath="username" namePath="name" imageSize="small"}} @@ -59,7 +59,7 @@ {{!-- template-lint-disable --}}

{{html-safe bookmark.excerpt}}

 {{#if bookmark.user.avatar_template}} @@ -77,6 +77,6 @@ {{/each}}
- + diff --git a/app/assets/javascripts/discourse/app/templates/components/bookmark.hbs b/app/assets/javascripts/discourse/app/templates/components/bookmark.hbs index 6e038c999a..1a68db973f 100644 --- a/app/assets/javascripts/discourse/app/templates/components/bookmark.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/bookmark.hbs @@ -1,28 +1,28 @@ - - {{#if errorMessage}} + + {{#if this.errorMessage}}
-
{{errorMessage}}
+
{{this.errorMessage}}
{{/if}}
- +
- {{#if showOptions}} + {{#if this.showOptions}}
- +
{{/if}} - {{#if showExistingReminderAt }} + {{#if this.showExistingReminderAt }}
{{d-icon "far-clock"}} - {{i18n "bookmarks.reminders.existing_reminder" at_date_time=existingReminderAtFormatted}} + {{i18n "bookmarks.reminders.existing_reminder" at_date_time=this.existingReminderAtFormatted}}
{{/if}} @@ -31,8 +31,8 @@ {{i18n "post.bookmarks.set_reminder"}} - {{#if userHasTimezoneSet}} - + {{#if this.userHasTimezoneSet}} + {{else}}
{{html-safe (i18n "bookmarks.no_timezone" basePath=(base-path))}}
{{/if}} @@ -41,7 +41,7 @@
- {{#if showDelete}} + {{#if this.showDelete}} {{/if}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs b/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs index 21fcaeb698..8b41ec852e 100644 --- a/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs @@ -1,7 +1,7 @@ -{{#each categoryBreadcrumbs as |breadcrumb|}} +{{#each this.categoryBreadcrumbs as |breadcrumb|}} {{#if breadcrumb.hasOptions}}
  • - -
    • {{else}}
  • - +
    • {{/if}} {{/if}} diff --git a/app/assets/javascripts/discourse/app/templates/components/cancel-link.hbs b/app/assets/javascripts/discourse/app/templates/components/cancel-link.hbs index cdef7f3c20..a112afac46 100644 --- a/app/assets/javascripts/discourse/app/templates/components/cancel-link.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/cancel-link.hbs @@ -1,3 +1,3 @@ - + {{i18n "cancel"}} diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs index 73b51ca62b..d0aad86c7f 100644 --- a/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs @@ -1,9 +1,9 @@
    - +
    - +
    diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs index 2d33841cca..dcd76823c2 100644 --- a/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs @@ -1,9 +1,9 @@
    - +
    - +
    diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-boxes-topic.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-boxes-topic.hbs index 988069494c..e35b16d0ff 100644 --- a/app/assets/javascripts/discourse/app/templates/components/categories-boxes-topic.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/categories-boxes-topic.hbs @@ -1,5 +1,5 @@ -{{d-icon topicStatusIcon}} +{{d-icon this.topicStatusIcon}} - - {{html-safe topic.fancyTitle}} + + {{html-safe this.topic.fancyTitle}} diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs index 1a51503483..f2b2c622ec 100644 --- a/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs @@ -1,5 +1,5 @@ -{{#each categories as |c|}} -
    +{{#each this.categories as |c|}} +
    @@ -12,7 +12,7 @@

    {{#if c.read_restricted}} - {{d-icon lockIcon}} + {{d-icon this.lockIcon}} {{/if}} {{c.name}}

    diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-boxes.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-boxes.hbs index b1da9f26f3..844cc9f0e7 100644 --- a/app/assets/javascripts/discourse/app/templates/components/categories-boxes.hbs +++ b/app/assets/javascripts/discourse/app/templates/components/categories-boxes.hbs @@ -1,7 +1,7 @@ -{{#each categories as |c|}} +{{#each this.categories as |c|}} -
    +
    {{#unless c.isMuted}}