From 39aebeac60062ac19d18e6509db11727018bcdfb Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Fri, 17 Mar 2023 16:50:06 +0100 Subject: [PATCH] moves polymorphic_class_for in registered_bookmarkable_from_type --- app/models/bookmark.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/models/bookmark.rb b/app/models/bookmark.rb index be664d346e..498dd6d593 100644 --- a/app/models/bookmark.rb +++ b/app/models/bookmark.rb @@ -10,7 +10,8 @@ class Bookmark < ActiveRecord::Base Set.new(DEFAULT_BOOKMARKABLES | DiscoursePluginRegistry.bookmarkables) end - def self.registered_bookmarkable_from_type(type) + def self.registered_bookmarkable_from_type(bookmarkable_type) + type = Bookmark.polymorphic_class_for(bookmarkable_type).name Bookmark.registered_bookmarkables.find { |bm| bm.model.name == type } end @@ -46,8 +47,7 @@ class Bookmark < ActiveRecord::Base validates :name, length: { maximum: 100 } def registered_bookmarkable - type = Bookmark.polymorphic_class_for(self.bookmarkable_type).name - Bookmark.registered_bookmarkable_from_type(type) + Bookmark.registered_bookmarkable_from_type(self.bookmarkable_type) end def polymorphic_columns_present