select-kit refactoring

* improve events naming/handling
* do not explicitly check for true/Fasle
* make sure header is re-computed on toggle

test/javascripts/components/single-select-test.js.es6

@@ -469,58 +469,6 @@ componentTest('with collection header', {
   }
 });
 
-componentTest('with onToggle', {
-  template: '{{single-select onToggle=onToggle}}',
-
-  beforeEach() {
-    this.set("onToggle", () => $(".select-kit").append("<span class='onToggleTest'></span>"));
-  },
-
-  test(assert) {
-    andThen(() => assert.notOk(exists(".onToggleTest")));
-
-    this.get('subject').expand();
-
-    andThen(() => assert.ok(exists(".onToggleTest")));
-  }
-});
-
-componentTest('with onExpand', {
-  template: '{{single-select onExpand=onExpand}}',
-
-  beforeEach() {
-    this.set("onExpand", () => $(".select-kit").append("<span class='onExpandTest'></span>"));
-  },
-
-  test(assert) {
-    andThen(() => assert.notOk(exists(".onExpandTest")));
-
-    this.get('subject').expand();
-
-    andThen(() => assert.ok(exists(".onExpandTest")));
-  }
-});
-
-componentTest('with onCollapse', {
-  template: '{{single-select onCollapse=onCollapse}}',
-
-  beforeEach() {
-    this.set("onCollapse", () => $(".select-kit").append("<span class='onCollapseTest'></span>"));
-  },
-
-  test(assert) {
-    andThen(() => assert.notOk(exists(".onCollapseTest")));
-
-    this.get('subject').expand();
-
-    andThen(() => assert.notOk(exists(".onCollapseTest")));
-
-    this.get('subject').collapse();
-
-    andThen(() => assert.ok(exists(".onCollapseTest")));
-  }
-});
-
 componentTest('with title', {
   template: '{{single-select title=(i18n "test.title")}}',
 

test/javascripts/helpers/select-kit-helper.js

@@ -87,7 +87,7 @@ function selectKit(selector) { // eslint-disable-line no-unused-vars
         var type = options.type || 'keydown';
         var event = jQuery.Event(type);
         event.keyCode = keyCode;
-        if (options && options.metaKey === true) { event.metaKey = true; }
+        if (options && options.metaKey) { event.metaKey = true; }
         find(eventSelector).trigger(event);
       });
     }