From 42b451ef8ab5610b2b2e0ff76357ff8eeb377214 Mon Sep 17 00:00:00 2001
From: Sam <sam.saffron@gmail.com>
Date: Tue, 28 Feb 2023 11:35:19 +1100
Subject: [PATCH] FIX: autocomplete failing for :( (#20461)

Composer was not completing :( (sad face) correctly given guessing of term
was not allowing for special chars.

New algorithm allows everything but space.

see: https://meta.discourse.org/t/some-emojis-added-with-enter-immediately-following-a-quote-will-break-the-quote/256219
---
 .../discourse/app/lib/autocomplete.js         |  2 +-
 .../tests/unit/lib/autocomplete-test.js       | 49 +++++++++++++++++++
 2 files changed, 50 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/discourse/app/lib/autocomplete.js b/app/assets/javascripts/discourse/app/lib/autocomplete.js
index 974856e5c2..6c4bfc1a2b 100644
--- a/app/assets/javascripts/discourse/app/lib/autocomplete.js
+++ b/app/assets/javascripts/discourse/app/lib/autocomplete.js
@@ -618,7 +618,7 @@ export default function (options) {
           break;
         }
       }
-      prevIsGood = !allowedLettersRegex.test(prev);
+      prevIsGood = !/\s/.test(prev);
       if (completeTermOption) {
         prevIsGood ||= prev === " ";
       }
diff --git a/app/assets/javascripts/discourse/tests/unit/lib/autocomplete-test.js b/app/assets/javascripts/discourse/tests/unit/lib/autocomplete-test.js
index acfa61dfb2..eb33b62f11 100644
--- a/app/assets/javascripts/discourse/tests/unit/lib/autocomplete-test.js
+++ b/app/assets/javascripts/discourse/tests/unit/lib/autocomplete-test.js
@@ -66,6 +66,55 @@ module("Unit | Utility | autocomplete", function (hooks) {
     );
   }
 
+  test("Autocomplete can complete really short terms correctly", async function (assert) {
+    let element = textArea("");
+    let $element = $(element);
+
+    autocomplete.call($element, {
+      key: ":",
+      transformComplete: () => "sad:",
+      dataSource: () => [":sad:"],
+      template: compile(`<div id='ac-testing' class='autocomplete ac-test'>
+  <ul>
+    {{#each options as |option|}}
+      <li>
+        <a href>
+          {{option}}
+        </a>
+      </li>
+    {{/each}}
+  </ul>
+</div>`),
+    });
+
+    simulateKey(element, "a");
+    simulateKey(element, " ");
+
+    simulateKey(element, ":");
+    simulateKey(element, ")");
+    simulateKey(element, "\r");
+
+    let sleep = (millisecs) =>
+      new Promise((promise) => setTimeout(promise, millisecs));
+    // completeTerm awaits transformComplete
+    // we need to wait for it to be done
+    // Note: this is somewhat questionable given that when people
+    // press ENTER on an autocomplete they do not want to be beholden
+    // to an async function.
+    let inputEquals = async function (value) {
+      let count = 3000;
+      while (count > 0 && element.value !== value) {
+        count -= 1;
+        await sleep(1);
+      }
+    };
+
+    await inputEquals("a :sad: ");
+    assert.strictEqual(element.value, "a :sad: ");
+    assert.strictEqual(element.selectionStart, 8);
+    assert.strictEqual(element.selectionEnd, 8);
+  });
+
   test("Autocomplete can account for cursor drift correctly", function (assert) {
     let element = textArea("");
     let $element = $(element);