From 4422d9a4bf4fb50b9f44ba2e29d48802f2e958d7 Mon Sep 17 00:00:00 2001
From: Robin Ward <robin.ward@gmail.com>
Date: Tue, 12 Nov 2019 13:04:14 -0500
Subject: [PATCH] DEV: Provide a nicer error when JSON is malformed

This is very useful for development. It will give a much nicer error if
the JSON that comes back from the server is missing a required key.
---
 app/assets/javascripts/discourse/models/store.js.es6 | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/assets/javascripts/discourse/models/store.js.es6 b/app/assets/javascripts/discourse/models/store.js.es6
index 14d479264a..9ece6af004 100644
--- a/app/assets/javascripts/discourse/models/store.js.es6
+++ b/app/assets/javascripts/discourse/models/store.js.es6
@@ -219,6 +219,13 @@ export default EmberObject.extend({
   _resultSet(type, result, findArgs) {
     const adapter = this.adapterFor(type);
     const typeName = underscore(this.pluralize(adapter.apiNameFor(type)));
+
+    if (!result[typeName]) {
+      // eslint-disable-next-line no-console
+      console.error(`JSON response is missing \`${typeName}\` key`, result);
+      return;
+    }
+
     const content = result[typeName].map(obj =>
       this._hydrate(type, obj, result)
     );