From 468417a7162a5337fe99a4fdbea51cd51c4ad49a Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Fri, 11 Sep 2020 10:08:06 +0800 Subject: [PATCH] PERF: Fix broken memoization in `GroupShowSerializer`. --- app/serializers/group_show_serializer.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/serializers/group_show_serializer.rb b/app/serializers/group_show_serializer.rb index 17e11ac7d2..29a81c645a 100644 --- a/app/serializers/group_show_serializer.rb +++ b/app/serializers/group_show_serializer.rb @@ -58,6 +58,7 @@ class GroupShowSerializer < BasicGroupSerializer end def fetch_group_user - @group_user ||= object.group_users.find_by(user: scope.user) + return @group_user if defined?(@group_user) + @group_user = object.group_users.find_by(user: scope.user) end end