From 4699136d83e52c4018abc9952b7dc1ba8a0fa102 Mon Sep 17 00:00:00 2001 From: riking Date: Tue, 18 Mar 2014 18:28:04 -0700 Subject: [PATCH] Fix this/self usage warning To clarify the intent of using 'this' inside the closure, it is first assigned to a variable. --- app/assets/javascripts/discourse/lib/page_tracker.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/lib/page_tracker.js b/app/assets/javascripts/discourse/lib/page_tracker.js index d8a74a148a..cd581ee01e 100644 --- a/app/assets/javascripts/discourse/lib/page_tracker.js +++ b/app/assets/javascripts/discourse/lib/page_tracker.js @@ -22,7 +22,8 @@ Discourse.PageTracker = Ember.Object.extend(Ember.Evented, { self = this; router.on('didTransition', function() { - self.trigger('change', this.get('url')); + var router = this; + self.trigger('change', router.get('url')); }); this.set('started', true); }