From 494fe335d3cd6f217d641992c2d23f470eb05241 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Mon, 9 Dec 2019 18:40:10 +1100 Subject: [PATCH] DEV: allow handling crawler reqs with no user agent Followup to e440ec25 we treat no user agent as crawler reqs. --- lib/middleware/request_tracker.rb | 2 +- spec/components/hijack_spec.rb | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/middleware/request_tracker.rb b/lib/middleware/request_tracker.rb index 5f3a1f7458..41ad8a60b4 100644 --- a/lib/middleware/request_tracker.rb +++ b/lib/middleware/request_tracker.rb @@ -118,7 +118,7 @@ class Middleware::RequestTracker if h[:is_crawler] user_agent = env['HTTP_USER_AGENT'] - if user_agent.encoding != Encoding::UTF_8 + if user_agent && (user_agent.encoding != Encoding::UTF_8) user_agent = user_agent.encode("utf-8") user_agent.scrub! end diff --git a/spec/components/hijack_spec.rb b/spec/components/hijack_spec.rb index a0ef15e97f..7e30a5439e 100644 --- a/spec/components/hijack_spec.rb +++ b/spec/components/hijack_spec.rb @@ -65,7 +65,6 @@ describe Hijack do expect(@calls).to eq(1) expect(@status).to eq(201) - expect(@status).to be > 0 end end