From 4d137b4f89d18fa4d6448f4e516f220a1df2ba0b Mon Sep 17 00:00:00 2001 From: Rafael dos Santos Silva Date: Mon, 11 May 2020 13:32:37 -0300 Subject: [PATCH] FIX: Handle a deleted topic in thumbnail generation Follow up to 03818e642a1ae871bffdc0c39c10f05f0b8b0398 A topic can be deleted between job enqueue and job execution --- app/jobs/regular/generate_topic_thumbnails.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/jobs/regular/generate_topic_thumbnails.rb b/app/jobs/regular/generate_topic_thumbnails.rb index a01452670c..e670e0fe41 100644 --- a/app/jobs/regular/generate_topic_thumbnails.rb +++ b/app/jobs/regular/generate_topic_thumbnails.rb @@ -10,8 +10,8 @@ module Jobs raise Discourse::InvalidParameters.new(:topic_id) if topic_id.blank? - topic = Topic.find(topic_id) - topic.generate_thumbnails!(extra_sizes: extra_sizes) + topic = Topic.find_by(id: topic_id) + topic&.generate_thumbnails!(extra_sizes: extra_sizes) end end