From 52a142ac637151ab6ebc00a63eb8c2f9f5f46e32 Mon Sep 17 00:00:00 2001
From: Ted Johansson <ted@discourse.org>
Date: Fri, 10 Mar 2023 16:51:31 +0800
Subject: [PATCH] DEV: Default num_auto_bump_daily to 0

---
 app/models/category.rb                        |  2 +-
 app/models/category_setting.rb                |  2 +-
 ...ory_setting_num_auto_bump_daily_default.rb | 23 +++++++++++++++++++
 3 files changed, 25 insertions(+), 2 deletions(-)
 create mode 100644 db/migrate/20230310082546_change_category_setting_num_auto_bump_daily_default.rb

diff --git a/app/models/category.rb b/app/models/category.rb
index 427dbc3fe6..684c68d49c 100644
--- a/app/models/category.rb
+++ b/app/models/category.rb
@@ -645,7 +645,7 @@ class Category < ActiveRecord::Base
       .joins(:category_setting)
       .where("category_settings.num_auto_bump_daily > 0")
       .shuffle
-      .any? { |c| c.auto_bump_topic! }
+      .any?(&:auto_bump_topic!)
   end
 
   # will automatically bump a single topic
diff --git a/app/models/category_setting.rb b/app/models/category_setting.rb
index 4506d634af..8c70964e56 100644
--- a/app/models/category_setting.rb
+++ b/app/models/category_setting.rb
@@ -26,7 +26,7 @@ end
 #  category_id             :bigint           not null
 #  require_topic_approval  :boolean
 #  require_reply_approval  :boolean
-#  num_auto_bump_daily     :integer
+#  num_auto_bump_daily     :integer          default(0)
 #  created_at              :datetime         not null
 #  updated_at              :datetime         not null
 #  auto_bump_cooldown_days :integer          default(1)
diff --git a/db/migrate/20230310082546_change_category_setting_num_auto_bump_daily_default.rb b/db/migrate/20230310082546_change_category_setting_num_auto_bump_daily_default.rb
new file mode 100644
index 0000000000..89c0d72004
--- /dev/null
+++ b/db/migrate/20230310082546_change_category_setting_num_auto_bump_daily_default.rb
@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+class ChangeCategorySettingNumAutoBumpDailyDefault < ActiveRecord::Migration[7.0]
+  def up
+    change_column_default :category_settings, :num_auto_bump_daily, 0
+
+    execute(<<~SQL)
+      UPDATE category_settings
+      SET num_auto_bump_daily = 0
+      WHERE num_auto_bump_daily IS NULL;
+    SQL
+  end
+
+  def down
+    change_column_default :category_settings, :num_auto_bump_daily, nil
+
+    execute(<<~SQL)
+      UPDATE category_settings
+      SET num_auto_bump_daily = NULL
+      WHERE num_auto_bump_daily = 0;
+    SQL
+  end
+end