osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove Discourse.SiteSettings from tests (#10193)

Browse Source 
* Remove unused Discourse.SiteSettings

* Remove `Discourse.SiteSettings` from many tests

* REFACTOR: `lib:formatter` was using a lot of leaky state

* Remove more `Discourse.SiteSettings` from tests

* More SiteSettings removed from tests
This commit is contained in:
Robin Ward
2020-07-09 15:54:53 -04:00
committed by GitHub
parent b1c6ff9e1c
commit 5b276af921
19 changed files with 252 additions and 218 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/javascripts/acceptance/enforce-second-factor-test.js
+7 -7
View File
@@ -12,9 +12,9 @@ acceptance("Enforce Second Factor", {
}
});
QUnit.test("as an admin", async assert => {
QUnit.test("as an admin", async function(assert) {
await visit("/u/eviltrout/preferences/second-factor");
Discourse.SiteSettings.enforce_second_factor = "staff";
this.siteSettings.enforce_second_factor = "staff";
await visit("/u/eviltrout/summary");
@@ -34,11 +34,11 @@ QUnit.test("as an admin", async assert => {
);
});
QUnit.test("as a user", async assert => {
QUnit.test("as a user", async function(assert) {
updateCurrentUser({ moderator: false, admin: false });
await visit("/u/eviltrout/preferences/second-factor");
Discourse.SiteSettings.enforce_second_factor = "all";
this.siteSettings.enforce_second_factor = "all";
await visit("/u/eviltrout/summary");
@@ -58,12 +58,12 @@ QUnit.test("as a user", async assert => {
);
});
QUnit.test("as an anonymous user", async assert => {
QUnit.test("as an anonymous user", async function(assert) {
updateCurrentUser({ moderator: false, admin: false, is_anonymous: true });
await visit("/u/eviltrout/preferences/second-factor");
Discourse.SiteSettings.enforce_second_factor = "all";
Discourse.SiteSettings.allow_anonymous_posting = true;
this.siteSettings.enforce_second_factor = "all";
this.siteSettings.allow_anonymous_posting = true;
await visit("/u/eviltrout/summary");