osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove Discourse.SiteSettings from tests (#10193)

Browse Source 
* Remove unused Discourse.SiteSettings

* Remove `Discourse.SiteSettings` from many tests

* REFACTOR: `lib:formatter` was using a lot of leaky state

* Remove more `Discourse.SiteSettings` from tests

* More SiteSettings removed from tests
This commit is contained in:
Robin Ward
2020-07-09 15:54:53 -04:00
committed by GitHub
parent b1c6ff9e1c
commit 5b276af921
19 changed files with 252 additions and 218 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/javascripts/controllers/create-account-test.js
+6 -11
View File
@@ -1,10 +1,7 @@
import I18n from "I18n";
import { mapRoutes } from "discourse/mapping-router";
import { controllerModule } from "helpers/qunit-helpers";
moduleFor("controller:create-account", "controller:create-account", {
beforeEach() {
this.registry.register("router:main", mapRoutes());
},
controllerModule("controller:create-account", {
needs: ["controller:modal", "controller:login"]
});
@@ -12,7 +9,7 @@ test("basicUsernameValidation", async function(assert) {
const subject = this.subject;
const testInvalidUsername = async (username, expectedReason) => {
const controller = await subject({ siteSettings: Discourse.SiteSettings });
const controller = await subject();
controller.set("accountUsername", username);
assert.equal(
@@ -34,7 +31,7 @@ test("basicUsernameValidation", async function(assert) {
I18n.t("user.username.too_long")
);
const controller = await subject({ siteSettings: Discourse.SiteSettings });
const controller = await subject();
controller.setProperties({
accountUsername: "porkchops",
prefilledUsername: "porkchops"
@@ -53,9 +50,7 @@ test("basicUsernameValidation", async function(assert) {
});
test("passwordValidation", async function(assert) {
const controller = await this.subject({
siteSettings: Discourse.SiteSettings
});
const controller = await this.subject();
controller.set("passwordRequired", true);
controller.set("accountEmail", "pork@chops.com");
@@ -92,7 +87,7 @@ test("passwordValidation", async function(assert) {
});
test("authProviderDisplayName", async function(assert) {
const controller = this.subject({ siteSettings: Discourse.SiteSettings });
const controller = this.subject();
assert.equal(
controller.authProviderDisplayName("facebook"),