From 5b9a3f8acd9313017c8f6ac348d838d7cc337b7d Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Thu, 27 Jun 2019 10:19:55 +0200 Subject: [PATCH] DEV: attempts to make load-script more reliable (#7816) We don't check on script anymore, but we still check on window.ace making very unlikely to regress. --- test/javascripts/lib/load-script-test.js.es6 | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/test/javascripts/lib/load-script-test.js.es6 b/test/javascripts/lib/load-script-test.js.es6 index d5b293daac..8ffc13840a 100644 --- a/test/javascripts/lib/load-script-test.js.es6 +++ b/test/javascripts/lib/load-script-test.js.es6 @@ -5,20 +5,18 @@ QUnit.module("lib:load-script"); QUnit.test( "load with a script tag, and callbacks are only executed after script is loaded", async assert => { + assert.ok( + typeof window.ace === "undefined", + "ensures ace is not previously loaded" + ); + const src = "/javascripts/ace/ace.js"; await loadScript(src).then(() => { assert.ok( - typeof ace !== "undefined", + typeof window.ace !== "undefined", "callbacks should only be executed after the script has fully loaded" ); - - // cannot use the `find` test helper here because the script tag is injected outside of the test sandbox frame - const scriptTags = Array.from(document.getElementsByTagName("script")); - assert.ok( - scriptTags.some(scriptTag => scriptTag.src.includes(src)), - "the script should be loaded with a script tag" - ); }); } );