FEATURE: Chat and Sidebar are now on by default (#19406)

FEATURE: Chat and Sidebar are now on by default

- Set the sidebar site setting to be enabled by default
- Set the chat site setting to be enabled by default
- Updated existing specs that assumed the original default
- Use a migration to keep old defaults for existing sites

app/assets/javascripts/discourse/tests/acceptance/enforce-second-factor-test.js

@@ -25,6 +25,9 @@ acceptance("Enforce Second Factor", function (needs) {
       });
     });
   });
+  needs.settings({
+    navigation_menu: "legacy",
+  });
 
   test("as an admin", async function (assert) {
     await visit("/u/eviltrout/preferences/second-factor");

app/assets/javascripts/discourse/tests/acceptance/hamburger-menu-test.js

@@ -14,6 +14,9 @@ acceptance(
     needs.pretender((server, helper) => {
       server.get("/review/count.json", () => helper.response({ count: 3 }));
     });
+    needs.settings({
+      navigation_menu: "legacy",
+    });
     test("As a staff member", async function (assert) {
       updateCurrentUser({ moderator: true, admin: false });
 
@@ -28,7 +31,10 @@ acceptance(
   }
 );
 
-acceptance("Hamburger Menu accessibility", function () {
+acceptance("Hamburger Menu accessibility", function (needs) {
+  needs.settings({
+    navigation_menu: "legacy",
+  });
   test("Escape key closes hamburger menu", async function (assert) {
     await visit("/");
     await click("#toggle-hamburger-menu");

app/assets/javascripts/discourse/tests/acceptance/opengraph-tag-updater-test.js

@@ -8,6 +8,9 @@ acceptance("Opengraph Tag Updater", function (needs) {
       return helper.response({});
     });
   });
+  needs.settings({
+    navigation_menu: "legacy",
+  });
 
   test("updates OG title and URL", async function (assert) {
     await visit("/");