From 5db39cce932cff2fe626c18744c7bf2a9ce78445 Mon Sep 17 00:00:00 2001 From: Sam Date: Thu, 27 May 2021 11:45:12 +1000 Subject: [PATCH] UX: unconditionally focus modals (#13179) Previously auto focus would only work on modals that include buttons or inputs. To avoid a situation where information modals such as keyboard shortcuts do not get focus, simply focus on the close button as a fallback. --- app/assets/javascripts/discourse/app/components/d-modal.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/assets/javascripts/discourse/app/components/d-modal.js b/app/assets/javascripts/discourse/app/components/d-modal.js index 144a9cc37d..533e03a29b 100644 --- a/app/assets/javascripts/discourse/app/components/d-modal.js +++ b/app/assets/javascripts/discourse/app/components/d-modal.js @@ -141,6 +141,10 @@ export default Component.extend({ focusTarget = this.element.querySelector( ".modal-body input, .modal-body button, .modal-footer input, .modal-footer button" ); + + if (!focusTarget) { + focusTarget = this.element.querySelector(".modal-header button"); + } } if (focusTarget) { afterTransition(() => focusTarget.focus());