FEATURE: Promote bookmarks with reminders to core functionality (#9369)
The main thrust of this PR is to take all the conditional checks based on the `enable_bookmarks_with_reminders` away and only keep the code from the `true` path, making bookmarks with reminders the core bookmarks feature. There is also a migration to create `Bookmark` records out of `PostAction` bookmarks for a site. ### Summary * Remove logic based on whether enable_bookmarks_with_reminders is true. This site setting is now obsolete, the old bookmark functionality is being removed. Retain the setting and set the value to `true` in a migration. * Use the code from the rake task to create a database migration that creates bookmarks from post actions. * Change the bookmark report to read from the new table. * Get rid of old endpoints for bookmarks * Link to the new bookmarks list from the user summary page
This commit is contained in:
@@ -532,19 +532,19 @@ widgetTest("can't bookmark", {
|
||||
|
||||
widgetTest("bookmark", {
|
||||
template:
|
||||
'{{mount-widget widget="post" args=args toggleBookmark=(action "toggleBookmark")}}',
|
||||
'{{mount-widget widget="post" args=args toggleBookmarkWithReminder=(action "toggleBookmarkWithReminder")}}',
|
||||
beforeEach() {
|
||||
const args = { canBookmark: true };
|
||||
|
||||
this.set("args", args);
|
||||
this.on("toggleBookmark", () => (args.bookmarked = true));
|
||||
this.on(
|
||||
"toggleBookmarkWithReminder",
|
||||
() => (args.bookmarked_with_reminder = true)
|
||||
);
|
||||
},
|
||||
async test(assert) {
|
||||
assert.equal(find(".post-menu-area .bookmark").length, 1);
|
||||
assert.equal(find("button.bookmarked").length, 0);
|
||||
|
||||
await click("button.bookmark");
|
||||
assert.equal(find("button.bookmarked").length, 1);
|
||||
}
|
||||
});
|
||||
|
||||
|
||||
@@ -145,11 +145,9 @@ widgetTest("bookmarks", {
|
||||
const bookmark = find(".quick-access-panel li a")[0];
|
||||
assert.ok(bookmark);
|
||||
|
||||
assert.ok(bookmark.href.includes("/t/yelling-topic-title/119"));
|
||||
assert.ok(
|
||||
bookmark.href.includes("/t/how-to-check-the-user-level-via-ajax/11993")
|
||||
);
|
||||
assert.ok(
|
||||
bookmark.innerHTML.includes("Abhishek_Gupta"),
|
||||
bookmark.innerHTML.includes("someguy"),
|
||||
"should include the last poster's username"
|
||||
);
|
||||
assert.ok(
|
||||
|
||||
Reference in New Issue
Block a user