From 636b75fa162f52ca1573f1d7ca90567c2bdc1ba7 Mon Sep 17 00:00:00 2001 From: Vinoth Kannan Date: Thu, 16 May 2019 10:04:04 +0530 Subject: [PATCH] REFACTOR: remove duplicate reject loop and implicit return e8fafbc123170dd1f7d2a8adea4e7810585d3e76 --- app/models/post.rb | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/app/models/post.rb b/app/models/post.rb index df85b4c764..d8be7ea48f 100644 --- a/app/models/post.rb +++ b/app/models/post.rb @@ -959,13 +959,16 @@ class Post < ActiveRecord::Base end count = 0 - missing_post_uploads = missing_post_uploads.reject { |_, uploads| uploads.empty? } - missing_post_uploads.reject do |post_id, uploads| - PostCustomField.create!(post_id: post_id, name: Post::MISSING_UPLOADS, value: uploads.to_json) - count += uploads.count + missing_post_uploads = missing_post_uploads.reject do |post_id, uploads| + if uploads.present? + PostCustomField.create!(post_id: post_id, name: Post::MISSING_UPLOADS, value: uploads.to_json) + count += uploads.count + end + + uploads.empty? end - return { uploads: missing_uploads, post_uploads: missing_post_uploads, count: count } + { uploads: missing_uploads, post_uploads: missing_post_uploads, count: count } end private