From 667e68ec5856d256219e85f4cefb620d890834ba Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Wed, 19 Sep 2018 18:22:54 +0800 Subject: [PATCH] Prefer `create` over `create!` when not checking for response. --- app/jobs/onceoff.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/jobs/onceoff.rb b/app/jobs/onceoff.rb index cee3608902..284557ee55 100644 --- a/app/jobs/onceoff.rb +++ b/app/jobs/onceoff.rb @@ -19,7 +19,7 @@ class Jobs::Onceoff < Jobs::Base begin return if OnceoffLog.where(job_name: job_name).exists? && !args[:force] execute_onceoff(args) - OnceoffLog.create(job_name: job_name) + OnceoffLog.create!(job_name: job_name) ensure $redis.del(running_key_name) if has_lock end