osr-plastic/osr-discourse-src
Archived
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

DEV: rework the chat-live-pane

Browse Source 
This PR is introducing glimmer usage in the chat-live-pane, for components but also for models. RestModel usage has been dropped in favor of native classes.

Other changes/additions in this PR:

- sticky dates, scrolling will now keep the date separator of the current section at the top of the screen
- better unread management, marking a channel as unread will correctly mark the correct message and not mark the whole channel as read. Tracking state will also now correctly return unread count and unread mentions.
- adds an animation on bottom arrow
- better scrolling behavior, we should now always correctly keep the scroll position while loading more
- reactions are now more reactive, and will update their tooltip without needed to close/reopen it
- skeleton has been improved with placeholder images and reactions
- when making a reaction on the desktop message actions, the menu won't move anymore
- simplify logic and stop maintaining a list of unloaded messages
This commit is contained in:
Joffrey JAFFEUX
2023-03-02 16:34:25 +01:00
committed by GitHub
parent e206bd8907
commit 67c0498f64
118 changed files with 2550 additions and 2289 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/chat/test/javascripts/modifiers/track-message-visibility-test.js
-36
View File
@@ -1,36 +0,0 @@
import { render, waitFor } from "@ember/test-helpers";
import { exists } from "discourse/tests/helpers/qunit-helpers";
import { setupRenderingTest } from "discourse/tests/helpers/component-test";
import hbs from "htmlbars-inline-precompile";
import { module, test } from "qunit";
module(
"Discourse Chat | Modifier | track-message-visibility",
function (hooks) {
setupRenderingTest(hooks);
test("Marks message as visible when it intersects with the viewport", async function (assert) {
const template = hbs`<div {{chat/track-message-visibility}}></div>`;
await render(template);
await waitFor("div[data-visible=true]");
assert.ok(
exists("div[data-visible=true]"),
"message is marked as visible"
);
});
test("Marks message as visible when it doesn't intersect with the viewport", async function (assert) {
const template = hbs`<div style="display:none;" {{chat/track-message-visibility}}></div>`;
await render(template);
await waitFor("div[data-visible=false]");
assert.ok(
exists("div[data-visible=false]"),
"message is not marked as visible"
);
});
}
);