From 737c0a7b9ff50b3f99ba2bbf2fc88c72d35ce982 Mon Sep 17 00:00:00 2001
From: Alan Guo Xiang Tan <gxtan1990@gmail.com>
Date: Thu, 14 Jul 2022 15:27:01 +0800
Subject: [PATCH] DEV: Allow sidebar section caret title to be translated
 (#17491)

---
 .../app/templates/components/sidebar/section.hbs          | 2 +-
 .../tests/acceptance/sidebar-topics-section-test.js       | 8 ++++++++
 config/locales/client.en.yml                              | 1 +
 3 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/app/assets/javascripts/discourse/app/templates/components/sidebar/section.hbs b/app/assets/javascripts/discourse/app/templates/components/sidebar/section.hbs
index 82baf9b3b6..73f2893517 100644
--- a/app/assets/javascripts/discourse/app/templates/components/sidebar/section.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/sidebar/section.hbs
@@ -1,6 +1,6 @@
 <div class={{concat "sidebar-section-wrapper sidebar-section-" @sectionName}}>
   <div class="sidebar-section-header">
-    <button type="button" class="sidebar-section-header-caret" title="toggle section" {{on "click" this.toggleSectionDisplay}}>
+    <button type="button" class="sidebar-section-header-caret" title={{i18n "sidebar.toggle_section"}} {{on "click" this.toggleSectionDisplay}}>
       {{d-icon this.headerCaretIcon}}
     </button>
 
diff --git a/app/assets/javascripts/discourse/tests/acceptance/sidebar-topics-section-test.js b/app/assets/javascripts/discourse/tests/acceptance/sidebar-topics-section-test.js
index c390a709dc..7c0e8dc024 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/sidebar-topics-section-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/sidebar-topics-section-test.js
@@ -1,3 +1,5 @@
+import I18n from "I18n";
+
 import { test } from "qunit";
 import { click, currentURL, settled, visit } from "@ember/test-helpers";
 import {
@@ -64,6 +66,12 @@ acceptance("Sidebar - Topics Section", function (needs) {
       "shows content section"
     );
 
+    assert.strictEqual(
+      query(".sidebar-section-topics .sidebar-section-header-caret").title,
+      I18n.t("sidebar.toggle_section"),
+      "caret has the right title"
+    );
+
     await click(".sidebar-section-topics .sidebar-section-header-caret");
 
     assert.ok(
diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml
index e5da978e93..1d53cb4cd2 100644
--- a/config/locales/client.en.yml
+++ b/config/locales/client.en.yml
@@ -4054,6 +4054,7 @@ en:
     sidebar:
       unread_count: "%{count} unread"
       new_count: "%{count} new"
+      toggle_section: "toggle section"
       sections:
         messages:
           header_link_title: "personal messages"