From 7707e42441cb10457ca01e759f2ca24f9f4a768a Mon Sep 17 00:00:00 2001
From: Joe <33972521+hnb-ku@users.noreply.github.com>
Date: Tue, 13 Nov 2018 11:45:55 +0800
Subject: [PATCH] DEV: moves print-specific styles from internal style tag to
 external print sheet (#6581)

* DEV: removes internal styles from print view

* DEV: adds styles to print sheet
---
 app/assets/stylesheets/common/printer-friendly.scss |  9 ++++++++-
 app/views/topics/show.html.erb                      | 12 ------------
 2 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/app/assets/stylesheets/common/printer-friendly.scss b/app/assets/stylesheets/common/printer-friendly.scss
index e76d132bcf..d7d8e6824d 100644
--- a/app/assets/stylesheets/common/printer-friendly.scss
+++ b/app/assets/stylesheets/common/printer-friendly.scss
@@ -35,9 +35,16 @@
   .alert-info,
   .badge-category,
   .badge-category-bg,
-  .badge-notification.clicks {
+  .badge-notification.clicks,
+  .crawler-nav,
+  .powered-by-link {
     display: none !important;
   }
+  /* For readability */
+  a,
+  a:visited {
+    color: #0088cc !important;
+  }
   /* bottom border to help separate posts */
   div.row {
     border-top: 1px solid #aaa;
diff --git a/app/views/topics/show.html.erb b/app/views/topics/show.html.erb
index 15b72d539f..bcc2e6a140 100644
--- a/app/views/topics/show.html.erb
+++ b/app/views/topics/show.html.erb
@@ -104,18 +104,6 @@
 
 <% if @topic_view.print %>
   <% content_for :after_body do %>
-      <style media="print">
-        /* For readability */
-        a,
-        a:visited {
-          color: #0088cc !important;
-        }
-        /* hide crawler nav in print view */
-        .crawler-nav,
-        .powered-by-link {
-          display: none;
-        }
-      </style>
       <%= preload_script('print-page') %>
   <% end %>
 <% end %>