From 78d46a81e1b03af5368f1ca928d103799cefd4d5 Mon Sep 17 00:00:00 2001 From: Neil Lalonde Date: Mon, 9 Jun 2014 15:27:37 -0400 Subject: [PATCH] FIX: js needs to use same max username length as server --- .../javascripts/discourse/controllers/create-account.js.es6 | 2 +- .../discourse/templates/modal/create_account.js.handlebars | 2 +- test/javascripts/controllers/create_account_controller_test.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/controllers/create-account.js.es6 b/app/assets/javascripts/discourse/controllers/create-account.js.es6 index 91beec59f6..694c89d323 100644 --- a/app/assets/javascripts/discourse/controllers/create-account.js.es6 +++ b/app/assets/javascripts/discourse/controllers/create-account.js.es6 @@ -197,7 +197,7 @@ export default Discourse.Controller.extend(Discourse.ModalFunctionality, { } // If too long - if (this.get('accountUsername').length > 15) { + if (this.get('accountUsername').length > 20) { return Discourse.InputValidation.create({ failed: true, reason: I18n.t('user.username.too_long') diff --git a/app/assets/javascripts/discourse/templates/modal/create_account.js.handlebars b/app/assets/javascripts/discourse/templates/modal/create_account.js.handlebars index 4dfa9d191a..5413782705 100644 --- a/app/assets/javascripts/discourse/templates/modal/create_account.js.handlebars +++ b/app/assets/javascripts/discourse/templates/modal/create_account.js.handlebars @@ -30,7 +30,7 @@ - {{input value=accountUsername id="new-account-username" maxlength="15"}} + {{input value=accountUsername id="new-account-username" maxlength="20"}}  {{input-tip validation=usernameValidation}} diff --git a/test/javascripts/controllers/create_account_controller_test.js b/test/javascripts/controllers/create_account_controller_test.js index 45ca92ee8e..8bdd59f70f 100644 --- a/test/javascripts/controllers/create_account_controller_test.js +++ b/test/javascripts/controllers/create_account_controller_test.js @@ -10,7 +10,7 @@ test('basicUsernameValidation', function() { testInvalidUsername('', undefined); testInvalidUsername('x', I18n.t('user.username.too_short')); - testInvalidUsername('1234567890123456', I18n.t('user.username.too_long')); + testInvalidUsername('123456789012345678901', I18n.t('user.username.too_long')); var controller = controllerFor('create-account'); controller.set('accountUsername', 'porkchops');