diff --git a/app/controllers/forums_controller.rb b/app/controllers/forums_controller.rb index d11efb4b43..361e75cff9 100644 --- a/app/controllers/forums_controller.rb +++ b/app/controllers/forums_controller.rb @@ -9,6 +9,14 @@ class ForumsController < ActionController::Base after_action :add_readonly_header def status + if params[:cluster] + if GlobalSetting.cluster_name.nil? + return render plain: "cluster name not configured", status: 500 + elsif GlobalSetting.cluster_name != params[:cluster] + return render plain: "cluster name does not match", status: 500 + end + end + if $shutdown # rubocop:disable Style/GlobalVars render plain: "shutting down", status: (params[:shutdown_ok] ? 200 : 500) else diff --git a/config/discourse_defaults.conf b/config/discourse_defaults.conf index 3d6011588a..b7c10ed966 100644 --- a/config/discourse_defaults.conf +++ b/config/discourse_defaults.conf @@ -332,3 +332,7 @@ enable_email_sync_demon = false # this can easily lead to blocking sidekiq # on multisites we recommend a far lower number max_digests_enqueued_per_30_mins_per_site = 10000 + +# This cluster name can be passed to the /srv/status route to verify +# the application cluster is the same one you are expecting +cluster_name = diff --git a/spec/requests/forums_controller_spec.rb b/spec/requests/forums_controller_spec.rb index 9f3ff2784c..19b1c6420b 100644 --- a/spec/requests/forums_controller_spec.rb +++ b/spec/requests/forums_controller_spec.rb @@ -37,4 +37,31 @@ RSpec.describe ForumsController do end end + describe "cluster parameter" do + it "returns a 500 response if the cluster is not configured" do + get "/srv/status?cluster=abc" + expect(response.status).to eq(500) + expect(response.body).to include("not configured") + end + + it "returns a 500 response if the cluster does not match" do + global_setting(:cluster_name, "mycluster") + get "/srv/status?cluster=abc" + expect(response.status).to eq(500) + expect(response.body).to include("not match") + end + + it "returns a 200 response if the cluster does match" do + global_setting(:cluster_name, "mycluster") + get "/srv/status?cluster=abc" + expect(response.status).to eq(500) + expect(response.body).to include("not match") + end + + it "returns a 200 response when given shutdown_ok" do + get "/srv/status?shutdown_ok=1" + expect(response.status).to eq(200) + end + end + end