From 7aa68eaeabcf0779f6dd82e5abeec218ae71af54 Mon Sep 17 00:00:00 2001 From: Robin Ward Date: Mon, 6 Apr 2015 14:14:00 -0400 Subject: [PATCH] Rename "Integration" tests to "Acceptance" tests. The term "Acceptance" seems to have won out everywhere and I don't want our codebase to be confusing. --- .jshintrc | 1 - test/javascripts/helpers/qunit-helpers.js.es6 | 6 +++--- test/javascripts/integration/about-test.js.es6 | 3 ++- test/javascripts/integration/badges-test.js.es6 | 4 +++- .../integration/create-account-user-fields-test.js.es6 | 4 ++-- test/javascripts/integration/groups-test.js.es6 | 3 ++- test/javascripts/integration/header-anonymous-test.js.es6 | 3 ++- test/javascripts/integration/header-test-staff.js.es6 | 4 +++- test/javascripts/integration/login-required-test.js.es6 | 4 +++- test/javascripts/integration/modal-test.js.es6 | 3 ++- test/javascripts/integration/sign-in-test.js.es6 | 3 ++- test/javascripts/integration/static-test.js.es6 | 3 ++- test/javascripts/integration/topic-discovery-test.js.es6 | 3 ++- test/javascripts/integration/topic-test.js.es6 | 3 ++- test/javascripts/integration/unknown-test.js.es6 | 3 ++- test/javascripts/integration/user-card-test.js.es6 | 3 ++- test/javascripts/integration/user-test.js.es6 | 3 ++- test/javascripts/integration/users-test.js.es6 | 3 ++- 18 files changed, 38 insertions(+), 21 deletions(-) diff --git a/.jshintrc b/.jshintrc index f479939c92..962847d723 100644 --- a/.jshintrc +++ b/.jshintrc @@ -14,7 +14,6 @@ "moduleForComponent", "Pretender", "sandbox", - "integration", "controllerFor", "test", "ok", diff --git a/test/javascripts/helpers/qunit-helpers.js.es6 b/test/javascripts/helpers/qunit-helpers.js.es6 index 111180cc52..17b82bd171 100644 --- a/test/javascripts/helpers/qunit-helpers.js.es6 +++ b/test/javascripts/helpers/qunit-helpers.js.es6 @@ -2,8 +2,8 @@ import siteFixtures from 'fixtures/site_fixtures'; -function integration(name, options) { - module("Integration: " + name, { +function acceptance(name, options) { + module("Acceptance: " + name, { setup: function() { Ember.run(Discourse, Discourse.advanceReadiness); @@ -61,4 +61,4 @@ function fixture(selector) { return $("#qunit-fixture"); } -export { integration, controllerFor, asyncTestDiscourse, fixture }; +export { acceptance, controllerFor, asyncTestDiscourse, fixture }; diff --git a/test/javascripts/integration/about-test.js.es6 b/test/javascripts/integration/about-test.js.es6 index 586195ac11..b45675f1aa 100644 --- a/test/javascripts/integration/about-test.js.es6 +++ b/test/javascripts/integration/about-test.js.es6 @@ -1,4 +1,5 @@ -integration("About"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("About"); test("viewing", () => { visit("/about"); diff --git a/test/javascripts/integration/badges-test.js.es6 b/test/javascripts/integration/badges-test.js.es6 index 6ff2b3bf8c..31f8bec3b8 100644 --- a/test/javascripts/integration/badges-test.js.es6 +++ b/test/javascripts/integration/badges-test.js.es6 @@ -1,4 +1,6 @@ -integration("Badges"); +import { acceptance } from "helpers/qunit-helpers"; + +acceptance("Badges"); test("Visit Badge Pages", () => { visit("/badges"); diff --git a/test/javascripts/integration/create-account-user-fields-test.js.es6 b/test/javascripts/integration/create-account-user-fields-test.js.es6 index a3822f62bc..0b6fec4da4 100644 --- a/test/javascripts/integration/create-account-user-fields-test.js.es6 +++ b/test/javascripts/integration/create-account-user-fields-test.js.es6 @@ -1,6 +1,6 @@ -import { integration } from "helpers/qunit-helpers"; +import { acceptance } from "helpers/qunit-helpers"; -integration("Create Account - User Fields", { +acceptance("Create Account - User Fields", { site: { user_fields: [{"id":34,"name":"I've read the terms of service","field_type":"confirm","required":true}, {"id":35,"name":"What is your pet's name?","field_type":"text","required":true}, diff --git a/test/javascripts/integration/groups-test.js.es6 b/test/javascripts/integration/groups-test.js.es6 index 2f40696812..92010b24d8 100644 --- a/test/javascripts/integration/groups-test.js.es6 +++ b/test/javascripts/integration/groups-test.js.es6 @@ -1,4 +1,5 @@ -integration("Groups"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Groups"); test("Browsing Groups", () => { visit("/groups/discourse"); diff --git a/test/javascripts/integration/header-anonymous-test.js.es6 b/test/javascripts/integration/header-anonymous-test.js.es6 index 713b807ed7..ae6ca34d7c 100644 --- a/test/javascripts/integration/header-anonymous-test.js.es6 +++ b/test/javascripts/integration/header-anonymous-test.js.es6 @@ -1,4 +1,5 @@ -integration("Header (Anonymous)"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Header (Anonymous)"); test("header", () => { visit("/"); diff --git a/test/javascripts/integration/header-test-staff.js.es6 b/test/javascripts/integration/header-test-staff.js.es6 index bd126c0c3c..2f4db1aa2f 100644 --- a/test/javascripts/integration/header-test-staff.js.es6 +++ b/test/javascripts/integration/header-test-staff.js.es6 @@ -1,4 +1,6 @@ -integration("Header (Staff)", { +import { acceptance } from "helpers/qunit-helpers"; + +acceptance("Header (Staff)", { user: { username: 'test', staff: true, site_flagged_posts_count: 1 } diff --git a/test/javascripts/integration/login-required-test.js.es6 b/test/javascripts/integration/login-required-test.js.es6 index 082cc9b2ad..c3904b3911 100644 --- a/test/javascripts/integration/login-required-test.js.es6 +++ b/test/javascripts/integration/login-required-test.js.es6 @@ -1,4 +1,6 @@ -integration("Login Required", { +import { acceptance } from "helpers/qunit-helpers"; + +acceptance("Login Required", { settings: { login_required: true } diff --git a/test/javascripts/integration/modal-test.js.es6 b/test/javascripts/integration/modal-test.js.es6 index 2c5cc7f53a..e3f0986f01 100644 --- a/test/javascripts/integration/modal-test.js.es6 +++ b/test/javascripts/integration/modal-test.js.es6 @@ -1,4 +1,5 @@ -integration("Modal"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Modal"); test("modal", () => { visit('/'); diff --git a/test/javascripts/integration/sign-in-test.js.es6 b/test/javascripts/integration/sign-in-test.js.es6 index 0d665b4e6c..32ee35b031 100644 --- a/test/javascripts/integration/sign-in-test.js.es6 +++ b/test/javascripts/integration/sign-in-test.js.es6 @@ -1,4 +1,5 @@ -integration("Signing In"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Signing In"); test("sign in", () => { visit("/"); diff --git a/test/javascripts/integration/static-test.js.es6 b/test/javascripts/integration/static-test.js.es6 index 8b1b184e9c..e3ad8afa38 100644 --- a/test/javascripts/integration/static-test.js.es6 +++ b/test/javascripts/integration/static-test.js.es6 @@ -1,4 +1,5 @@ -integration("Static"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Static"); test("Static Pages", () => { visit("/faq"); diff --git a/test/javascripts/integration/topic-discovery-test.js.es6 b/test/javascripts/integration/topic-discovery-test.js.es6 index 729680336c..6ee69623d8 100644 --- a/test/javascripts/integration/topic-discovery-test.js.es6 +++ b/test/javascripts/integration/topic-discovery-test.js.es6 @@ -1,4 +1,5 @@ -integration("Topic Discovery"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Topic Discovery"); test("Visit Discovery Pages", () => { visit("/"); diff --git a/test/javascripts/integration/topic-test.js.es6 b/test/javascripts/integration/topic-test.js.es6 index 5757d4091a..53bf0c3391 100644 --- a/test/javascripts/integration/topic-test.js.es6 +++ b/test/javascripts/integration/topic-test.js.es6 @@ -1,4 +1,5 @@ -integration("View Topic"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("View Topic"); test("Enter a Topic", () => { visit("/t/internationalization-localization/280"); diff --git a/test/javascripts/integration/unknown-test.js.es6 b/test/javascripts/integration/unknown-test.js.es6 index c2b96f81a2..148d8d2eef 100644 --- a/test/javascripts/integration/unknown-test.js.es6 +++ b/test/javascripts/integration/unknown-test.js.es6 @@ -1,4 +1,5 @@ -integration("Unknown"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("Unknown"); test("Unknown URL", () => { expect(1); diff --git a/test/javascripts/integration/user-card-test.js.es6 b/test/javascripts/integration/user-card-test.js.es6 index 98a76828ae..4a4d7288bf 100644 --- a/test/javascripts/integration/user-card-test.js.es6 +++ b/test/javascripts/integration/user-card-test.js.es6 @@ -1,4 +1,5 @@ -integration("User Card"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("User Card"); test("card", () => { visit('/'); diff --git a/test/javascripts/integration/user-test.js.es6 b/test/javascripts/integration/user-test.js.es6 index ef8cd9aa30..9d38301ff1 100644 --- a/test/javascripts/integration/user-test.js.es6 +++ b/test/javascripts/integration/user-test.js.es6 @@ -1,4 +1,5 @@ -integration("User"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("User"); function hasStream() { andThen(() => { diff --git a/test/javascripts/integration/users-test.js.es6 b/test/javascripts/integration/users-test.js.es6 index 96f27623d1..8ae9cfb28f 100644 --- a/test/javascripts/integration/users-test.js.es6 +++ b/test/javascripts/integration/users-test.js.es6 @@ -1,4 +1,5 @@ -integration("User Directory"); +import { acceptance } from "helpers/qunit-helpers"; +acceptance("User Directory"); test("Visit Page", function() { visit("/users");