From 819d4facda2192b64dc18d874ff52c22ec157f71 Mon Sep 17 00:00:00 2001 From: Sam Date: Fri, 15 Mar 2019 11:30:17 +1100 Subject: [PATCH] FIX: ruby bench script no longer working The library used to generate random text changed, this caused the title of the topic used for testing to change, which meant the slug changed, so a hit to the topic was a redirect This fix gives the topic used for performance testing a static name to avoid this issue in future --- script/bench.rb | 2 +- script/profile_db_generator.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/script/bench.rb b/script/bench.rb index a93b44faa3..f474b02b5b 100644 --- a/script/bench.rb +++ b/script/bench.rb @@ -231,7 +231,7 @@ begin tests = [ ["categories", "/categories"], ["home", "/"], - ["topic", "/t/oh-how-i-wish-i-could-shut-up-like-a-tunnel-for-so/179"] + ["topic", "/t/i-am-a-topic-used-for-perf-tests/179"] # ["user", "/u/admin1/activity"], ] diff --git a/script/profile_db_generator.rb b/script/profile_db_generator.rb index f75ba4910e..8e5d8f139d 100644 --- a/script/profile_db_generator.rb +++ b/script/profile_db_generator.rb @@ -62,9 +62,17 @@ unless Rails.env == "profile" exit end +def ensure_perf_test_topic_has_right_title! + t = Topic.find(179) + t.title = "I am a topic used for perf tests" + t.save! if t.title_changed? +end + # by default, Discourse has a "system" and `discobot` account if User.count > 2 puts "Only run this script against an empty DB" + + ensure_perf_test_topic_has_right_title! exit end @@ -110,3 +118,5 @@ end # no sidekiq so update some stuff Category.update_stats Jobs::PeriodicalUpdates.new.execute(nil) + +ensure_perf_test_topic_has_right_title!