From 8e27fa1bd871272ee923ef948703afc02fb12e25 Mon Sep 17 00:00:00 2001 From: Dan Ungureanu Date: Wed, 12 Feb 2020 15:48:24 +0200 Subject: [PATCH] PERF: Optimize post editing Reordering the conditions reduced the execution time by a factor of 5. --- lib/post_revisor.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/post_revisor.rb b/lib/post_revisor.rb index d9647293f5..fbd9c012bf 100644 --- a/lib/post_revisor.rb +++ b/lib/post_revisor.rb @@ -359,7 +359,7 @@ class PostRevisor end POST_TRACKED_FIELDS.each do |field| - if @fields.has_key?(field) || (should_create_new_version? && field == "edit_reason") + if @fields.has_key?(field) || (field == "edit_reason" && should_create_new_version?) @post.public_send("#{field}=", @fields[field]) end end