From 926bd712bfa9dcffd053a633af425ebe0c618fd3 Mon Sep 17 00:00:00 2001 From: Sam Saffron Date: Fri, 4 Oct 2019 11:11:03 +1000 Subject: [PATCH] DEV: improve flaky spec This handles a lot of date calculations, keep the baseline time consistent so it is not prone to issues when running out UTC threshold --- spec/models/directory_item_spec.rb | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/spec/models/directory_item_spec.rb b/spec/models/directory_item_spec.rb index 54f8d72951..fd8971fa26 100644 --- a/spec/models/directory_item_spec.rb +++ b/spec/models/directory_item_spec.rb @@ -51,6 +51,7 @@ describe DirectoryItem do context 'refresh' do before do + freeze_time DateTime.parse('2017-02-02 12:00') UserActionManager.enable end @@ -89,11 +90,13 @@ describe DirectoryItem do it "handles users with no activity" do post = nil - freeze_time(2.years.ago) do - post = create_post - # Create records for that activity - DirectoryItem.refresh! - end + freeze_time(2.years.ago) + + post = create_post + # Create records for that activity + DirectoryItem.refresh! + + freeze_time(2.years.from_now) DirectoryItem.refresh! [:yearly, :monthly, :weekly, :daily, :quarterly].each do |period|