From 92bfea2f2ba994001679f2b943a38b1af09005eb Mon Sep 17 00:00:00 2001
From: chapoi <101828855+chapoi@users.noreply.github.com>
Date: Fri, 14 Oct 2022 03:26:21 +0200
Subject: [PATCH] UX: hide keyboard shortcuts on mobile (#18575)

---
 .../discourse/app/components/sidebar/footer.hbs      | 12 +++++++-----
 .../tests/acceptance/sidebar-mobile-test.js          | 10 ++++++++++
 2 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/components/sidebar/footer.hbs b/app/assets/javascripts/discourse/app/components/sidebar/footer.hbs
index 1f7aae7831..59c181b360 100644
--- a/app/assets/javascripts/discourse/app/components/sidebar/footer.hbs
+++ b/app/assets/javascripts/discourse/app/components/sidebar/footer.hbs
@@ -9,11 +9,13 @@
           @class="sidebar-footer-actions-button sidebar-footer-actions-toggle-mobile-view" />
       {{/if}}
 
-      <DButton
-        @action={{route-action "showKeyboardShortcutsHelp"}}
-        @title="keyboard_shortcuts_help.title"
-        @icon="keyboard"
-        @class="sidebar-footer-actions-button sidebar-footer-actions-keyboard-shortcuts" />
+      {{#if this.site.desktopView}}
+        <DButton
+          @action={{route-action "showKeyboardShortcutsHelp"}}
+          @title="keyboard_shortcuts_help.title"
+          @icon="keyboard"
+          @class="sidebar-footer-actions-button sidebar-footer-actions-keyboard-shortcuts" />
+      {{/if}}
     </div>
   </div>
 </div>
diff --git a/app/assets/javascripts/discourse/tests/acceptance/sidebar-mobile-test.js b/app/assets/javascripts/discourse/tests/acceptance/sidebar-mobile-test.js
index 64bfe6c65e..3241278e81 100644
--- a/app/assets/javascripts/discourse/tests/acceptance/sidebar-mobile-test.js
+++ b/app/assets/javascripts/discourse/tests/acceptance/sidebar-mobile-test.js
@@ -74,4 +74,14 @@ acceptance("Sidebar - Mobile - User with sidebar enabled", function (needs) {
       "displays the desktop icon for the button"
     );
   });
+
+  test("keyboard shortcuts button is hidden", async function (assert) {
+    await visit("/");
+    await click(".hamburger-dropdown");
+
+    assert.notOk(
+      exists(".sidebar-footer-actions-keyboard-shortcuts"),
+      "keyboard shortcuts button is not shown on mobile"
+    );
+  });
 });