From 98039e6cc5eff656f71231d8dfd2641f552cdfd8 Mon Sep 17 00:00:00 2001 From: Joffrey JAFFEUX Date: Thu, 16 Apr 2020 22:38:10 +0200 Subject: [PATCH] FIX: template-lint uses strict rel-noopener rule which requires noreferrer (#9449) --- .template-lintrc.js | 4 ++-- app/assets/javascripts/admin/templates/badges-index.hbs | 2 +- .../javascripts/admin/templates/components/admin-report.hbs | 2 +- .../admin/templates/components/version-checks.hbs | 2 +- .../javascripts/admin/templates/customize-themes-edit.hbs | 2 +- .../javascripts/admin/templates/customize-themes-index.hbs | 2 +- .../javascripts/admin/templates/customize-themes-show.hbs | 6 +++--- .../javascripts/admin/templates/dashboard_general.hbs | 2 +- .../admin/templates/modal/admin-install-theme.hbs | 4 ++-- .../javascripts/admin/templates/modal/admin-theme-item.hbs | 2 +- app/assets/javascripts/admin/templates/plugins-index.hbs | 2 +- .../discourse/templates/components/backup-codes.hbs | 2 +- .../discourse/templates/components/ip-lookup.hbs | 2 +- .../discourse/templates/components/reviewable-user.hbs | 2 +- .../javascripts/discourse/templates/modal/publish-page.hbs | 2 +- .../javascripts/discourse/templates/review-topics.hbs | 2 +- app/assets/javascripts/discourse/templates/topic.hbs | 2 +- .../javascripts/discourse/templates/user-invited-show.hbs | 2 +- .../wizard/templates/components/popular-themes.hbs | 2 +- 19 files changed, 23 insertions(+), 23 deletions(-) diff --git a/.template-lintrc.js b/.template-lintrc.js index b0a14bbf22..d7b4a104eb 100644 --- a/.template-lintrc.js +++ b/.template-lintrc.js @@ -10,7 +10,7 @@ module.exports = { "deprecated-render-helper": true, "require-valid-alt-text": false, "linebreak-style": true, - "link-rel-noopener": true, + "link-rel-noopener": "strict", "no-abstract-roles": true, "no-args-paths": true, "no-attrs-in-components": true, @@ -43,7 +43,7 @@ module.exports = { "no-unnecessary-concat": true, "no-unnecessary-component-helper": true, "no-unused-block-params": true, - "quotes": "double", + quotes: "double", "require-button-type": true, "require-iframe-title": true, "require-valid-alt-text": false, diff --git a/app/assets/javascripts/admin/templates/badges-index.hbs b/app/assets/javascripts/admin/templates/badges-index.hbs index 7e2f21b127..4f26fde7f3 100644 --- a/app/assets/javascripts/admin/templates/badges-index.hbs +++ b/app/assets/javascripts/admin/templates/badges-index.hbs @@ -5,7 +5,7 @@

{{i18n "admin.badges.badge_intro.title"}}

{{#each badgeIntroLinks as |link|}} - + {{d-icon link.icon}} {{i18n link.text}} diff --git a/app/assets/javascripts/admin/templates/components/admin-report.hbs b/app/assets/javascripts/admin/templates/components/admin-report.hbs index eeb7894099..2aa3143a47 100644 --- a/app/assets/javascripts/admin/templates/components/admin-report.hbs +++ b/app/assets/javascripts/admin/templates/components/admin-report.hbs @@ -24,7 +24,7 @@ {{#if model.description}} {{#if model.description_link}} - + {{d-icon "question-circle"}} {{else}} diff --git a/app/assets/javascripts/admin/templates/components/version-checks.hbs b/app/assets/javascripts/admin/templates/components/version-checks.hbs index aa2fcc97c0..9471bcc980 100644 --- a/app/assets/javascripts/admin/templates/components/version-checks.hbs +++ b/app/assets/javascripts/admin/templates/components/version-checks.hbs @@ -18,7 +18,7 @@ {{#if versionCheck.gitLink}}
( - + {{versionCheck.shortSha}} ) diff --git a/app/assets/javascripts/admin/templates/customize-themes-edit.hbs b/app/assets/javascripts/admin/templates/customize-themes-edit.hbs index 31ad084c23..a4e7fa583f 100644 --- a/app/assets/javascripts/admin/templates/customize-themes-edit.hbs +++ b/app/assets/javascripts/admin/templates/customize-themes-edit.hbs @@ -15,7 +15,7 @@
{{#unless model.changed}} - + {{i18n "admin.customize.preview"}} {{/unless}} diff --git a/app/assets/javascripts/admin/templates/customize-themes-index.hbs b/app/assets/javascripts/admin/templates/customize-themes-index.hbs index 7402ef2724..fd1914a910 100644 --- a/app/assets/javascripts/admin/templates/customize-themes-index.hbs +++ b/app/assets/javascripts/admin/templates/customize-themes-index.hbs @@ -7,7 +7,7 @@
{{#each externalResources as |resource|}} - + {{d-icon resource.icon}} {{i18n resource.key}} diff --git a/app/assets/javascripts/admin/templates/customize-themes-show.hbs b/app/assets/javascripts/admin/templates/customize-themes-show.hbs index 186cd9b358..9f46d47d69 100644 --- a/app/assets/javascripts/admin/templates/customize-themes-show.hbs +++ b/app/assets/javascripts/admin/templates/customize-themes-show.hbs @@ -206,7 +206,7 @@
    {{#each model.uploads as |upload|}}
  • - ${{upload.name}}: {{upload.filename}} + ${{upload.name}}: {{upload.filename}} {{d-button action=(action "removeUpload") actionParam=upload class="second btn-default btn-default cancel-edit" icon="times"}} @@ -241,8 +241,8 @@
{{/if}} - {{d-icon "desktop"}}{{i18n "admin.customize.theme.preview"}} - {{d-icon "download"}} {{i18n "admin.export_json.button_text"}} + {{d-icon "desktop"}}{{i18n "admin.customize.theme.preview"}} + {{d-icon "download"}} {{i18n "admin.export_json.button_text"}} {{d-button action=(action "switchType") label="admin.customize.theme.convert" icon=convertIcon class="btn-default btn-normal" title=convertTooltip}} diff --git a/app/assets/javascripts/admin/templates/dashboard_general.hbs b/app/assets/javascripts/admin/templates/dashboard_general.hbs index 2eca2b7d02..16214a92e3 100644 --- a/app/assets/javascripts/admin/templates/dashboard_general.hbs +++ b/app/assets/javascripts/admin/templates/dashboard_general.hbs @@ -121,7 +121,7 @@

{{i18n "admin.dashboard.discourse_last_updated"}}

{{format-date model.attributes.discourse_updated_at leaveAgo="true"}}

- + {{i18n "admin.dashboard.whats_new_in_discourse"}}
diff --git a/app/assets/javascripts/admin/templates/modal/admin-install-theme.hbs b/app/assets/javascripts/admin/templates/modal/admin-install-theme.hbs index 6c8ab04311..604befe690 100644 --- a/app/assets/javascripts/admin/templates/modal/admin-install-theme.hbs +++ b/app/assets/javascripts/admin/templates/modal/admin-install-theme.hbs @@ -11,7 +11,7 @@ {{#each themes as |theme|}}
- + {{#if theme.component}} {{d-icon "puzzle-piece" title="admin.customize.theme.component"}} {{/if}} @@ -33,7 +33,7 @@ action=(action "installThemeFromList" theme.value)}} {{#if theme.preview}} - {{d-icon "desktop"}} {{i18n "admin.customize.theme.preview"}} + {{d-icon "desktop"}} {{i18n "admin.customize.theme.preview"}} {{/if}} {{/if}}
diff --git a/app/assets/javascripts/admin/templates/modal/admin-theme-item.hbs b/app/assets/javascripts/admin/templates/modal/admin-theme-item.hbs index 1a50682819..7a7198fd57 100644 --- a/app/assets/javascripts/admin/templates/modal/admin-theme-item.hbs +++ b/app/assets/javascripts/admin/templates/modal/admin-theme-item.hbs @@ -2,7 +2,7 @@
{{theme.name}} {{#if theme.preview}} - {{d-icon "far-eye"}} + {{d-icon "far-eye"}} {{/if}}
diff --git a/app/assets/javascripts/admin/templates/plugins-index.hbs b/app/assets/javascripts/admin/templates/plugins-index.hbs index e17804d7ff..b89b6e6f01 100644 --- a/app/assets/javascripts/admin/templates/plugins-index.hbs +++ b/app/assets/javascripts/admin/templates/plugins-index.hbs @@ -24,7 +24,7 @@ {{#if plugin.url}} - {{plugin.name}} + {{plugin.name}} {{else}} {{plugin.name}} {{/if}} diff --git a/app/assets/javascripts/discourse/templates/components/backup-codes.hbs b/app/assets/javascripts/discourse/templates/components/backup-codes.hbs index 046baed16a..73b7ad43aa 100644 --- a/app/assets/javascripts/discourse/templates/components/backup-codes.hbs +++ b/app/assets/javascripts/discourse/templates/components/backup-codes.hbs @@ -8,7 +8,7 @@ {{d-icon "download"}} diff --git a/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs b/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs index 3e57bd71d8..b6980b39d5 100644 --- a/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs +++ b/app/assets/javascripts/discourse/templates/components/ip-lookup.hbs @@ -25,7 +25,7 @@
{{i18n "ip_lookup.location"}}
{{#if location.location}} - + {{location.location}} {{else}} diff --git a/app/assets/javascripts/discourse/templates/components/reviewable-user.hbs b/app/assets/javascripts/discourse/templates/components/reviewable-user.hbs index 4c246153ce..be61c74e81 100644 --- a/app/assets/javascripts/discourse/templates/components/reviewable-user.hbs +++ b/app/assets/javascripts/discourse/templates/components/reviewable-user.hbs @@ -29,7 +29,7 @@
{{i18n "review.user.website"}}
- {{reviewable.payload.website}} + {{reviewable.payload.website}}
{{/if}} diff --git a/app/assets/javascripts/discourse/templates/modal/publish-page.hbs b/app/assets/javascripts/discourse/templates/modal/publish-page.hbs index a3c780ddbe..07c3640ddd 100644 --- a/app/assets/javascripts/discourse/templates/modal/publish-page.hbs +++ b/app/assets/javascripts/discourse/templates/modal/publish-page.hbs @@ -17,7 +17,7 @@
{{i18n "topic.publish_page.publish_url"}}
{{else}} diff --git a/app/assets/javascripts/discourse/templates/review-topics.hbs b/app/assets/javascripts/discourse/templates/review-topics.hbs index 337cb4207d..6bce353354 100644 --- a/app/assets/javascripts/discourse/templates/review-topics.hbs +++ b/app/assets/javascripts/discourse/templates/review-topics.hbs @@ -12,7 +12,7 @@
{{topic-status topic=rt}} - {{replace-emoji rt.fancy_title}} + {{replace-emoji rt.fancy_title}}
diff --git a/app/assets/javascripts/discourse/templates/topic.hbs b/app/assets/javascripts/discourse/templates/topic.hbs index 7a4f6d6c7e..a3068355d0 100644 --- a/app/assets/javascripts/discourse/templates/topic.hbs +++ b/app/assets/javascripts/discourse/templates/topic.hbs @@ -91,7 +91,7 @@
{{i18n "topic.publish_page.topic_published"}}
diff --git a/app/assets/javascripts/discourse/templates/user-invited-show.hbs b/app/assets/javascripts/discourse/templates/user-invited-show.hbs index 30aa848824..1def791972 100644 --- a/app/assets/javascripts/discourse/templates/user-invited-show.hbs +++ b/app/assets/javascripts/discourse/templates/user-invited-show.hbs @@ -17,7 +17,7 @@ {{d-button icon="plus" action=(route-action "showInvite") label="user.invited.create"}} {{#if canBulkInvite}} {{csv-uploader uploading=uploading}} - {{d-icon "question-circle"}} + {{d-icon "question-circle"}} {{/if}} {{#if showBulkActionButtons}} {{#if rescindedAll}} diff --git a/app/assets/javascripts/wizard/templates/components/popular-themes.hbs b/app/assets/javascripts/wizard/templates/components/popular-themes.hbs index 6f6ddf02ed..774f8c0a27 100644 --- a/app/assets/javascripts/wizard/templates/components/popular-themes.hbs +++ b/app/assets/javascripts/wizard/templates/components/popular-themes.hbs @@ -1,5 +1,5 @@ {{#each popular_components as |theme|}} - + {{theme.name}} {{/each}}