From 98aaad6675d3ffc38933921fa01acb61de0c560e Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Tue, 2 Oct 2018 12:26:16 -0400 Subject: [PATCH] Improve "hit area" for topic progress bar on mobile (#6442) * Improve "hit area" for topic progress bar on mobile * Only target admin wrench on mobile --- .../discourse/components/topic-progress.js.es6 | 2 +- app/assets/stylesheets/mobile/topic.scss | 14 ++++++++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/discourse/components/topic-progress.js.es6 b/app/assets/javascripts/discourse/components/topic-progress.js.es6 index 243d45625c..eca9ebb124 100644 --- a/app/assets/javascripts/discourse/components/topic-progress.js.es6 +++ b/app/assets/javascripts/discourse/components/topic-progress.js.es6 @@ -181,7 +181,7 @@ export default Ember.Component.extend({ }, click(e) { - if ($(e.target).parents("#topic-progress").length) { + if ($(e.target).closest("#topic-progress").length) { this.send("toggleExpansion"); } }, diff --git a/app/assets/stylesheets/mobile/topic.scss b/app/assets/stylesheets/mobile/topic.scss index 746cedfe1d..233af13bdf 100644 --- a/app/assets/stylesheets/mobile/topic.scss +++ b/app/assets/stylesheets/mobile/topic.scss @@ -61,6 +61,12 @@ bottom: 0; z-index: z("timeline"); margin-right: 148px; + .topic-admin-menu-button-container { + top: 43px; + .toggle-admin-menu { + height: 43px; + } + } } #topic-progress-expanded { @@ -104,6 +110,10 @@ } } +.progress-back-container { + bottom: 43px; +} + #topic-progress { position: relative; &.hidden { @@ -114,14 +124,14 @@ border: 1px solid $tertiary-low; border-bottom: none; width: 145px; - height: 46px; + height: 42px; /* as a big ol' click target, don't let text inside be selected */ @include unselectable; .nums { position: relative; - top: 13px; + top: 12px; width: 100%; text-align: center; z-index: z("base");