From a9713ca20b2afd7e5c7f69e8f2faf39d22ef106e Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Tue, 13 Mar 2018 12:01:01 +0800 Subject: [PATCH] REFACTOR: Always prefer to raise an error if record fails to save. --- lib/email/receiver.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/email/receiver.rb b/lib/email/receiver.rb index 2df138a986..68a75c621f 100644 --- a/lib/email/receiver.rb +++ b/lib/email/receiver.rb @@ -198,11 +198,11 @@ module Email if user = User.find_by_email(email) user.user_stat.bounce_score += score user.user_stat.reset_bounce_score_after = SiteSetting.reset_bounce_score_after_days.days.from_now - user.user_stat.save + user.user_stat.save! bounce_score = user.user_stat.bounce_score if user.active && bounce_score >= SiteSetting.bounce_score_threshold_deactivate - user.update_columns(active: false) + user.update!(active: false) reason = I18n.t("user.deactivated", email: user.email) StaffActionLogger.new(Discourse.system_user).log_user_deactivate(user, reason) elsif bounce_score >= SiteSetting.bounce_score_threshold