From a97e36cfdafa2320b578982b6cfa52ebced500ac Mon Sep 17 00:00:00 2001 From: Rafael dos Santos Silva Date: Fri, 7 Aug 2020 15:38:53 -0300 Subject: [PATCH] FEATURE: Block vibration in Firefox Android (#10389) Legacy Firefox Android has some quirks around vibration where it: - asks for permission - doesn't persist the permission This makes the default like vibration popup a permission on Firefox Android <= 68. This isn't the case (yet?) on their new Firefox which is rolling out worldwide right now. I'd say we merge this now and revert in 3 months or so when https://arewefenixyet.com/ shows a full rollout. --- .../discourse/app/pre-initializers/sniff-capabilities.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/pre-initializers/sniff-capabilities.js b/app/assets/javascripts/discourse/app/pre-initializers/sniff-capabilities.js index a3a3f76153..45d97e4738 100644 --- a/app/assets/javascripts/discourse/app/pre-initializers/sniff-capabilities.js +++ b/app/assets/javascripts/discourse/app/pre-initializers/sniff-capabilities.js @@ -46,7 +46,7 @@ export default { caps.hasContactPicker = "contacts" in navigator && "ContactsManager" in window; - caps.canVibrate = "vibrate" in navigator; + caps.canVibrate = "vibrate" in navigator && !caps.isFirefox; // Remove Firefox condition when https://arewefenixyet.com/ lands } // We consider high res a device with 1280 horizontal pixels. High DPI tablets like