From b2f556232f80b621ef0477e5ffb0adedb1bbfd0a Mon Sep 17 00:00:00 2001
From: jbrw <jamie.wilson@discourse.org>
Date: Mon, 14 Sep 2020 16:46:17 -0400
Subject: [PATCH] REFACTOR: improve readability of cacheBuster

---
 app/assets/javascripts/discourse/app/lib/load-script.js | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/app/assets/javascripts/discourse/app/lib/load-script.js b/app/assets/javascripts/discourse/app/lib/load-script.js
index a766581020..c5b87ca236 100644
--- a/app/assets/javascripts/discourse/app/lib/load-script.js
+++ b/app/assets/javascripts/discourse/app/lib/load-script.js
@@ -110,10 +110,11 @@ export default function loadScript(url, opts) {
 
 export function cacheBuster(url) {
   if (PUBLIC_JS_VERSIONS) {
-    const pathParts = url.split("/");
-    if (pathParts[1] === "javascripts") {
-      const version = PUBLIC_JS_VERSIONS[pathParts[2]];
-      if (typeof version !== "undefined") {
+    // eslint-disable-next-line no-unused-vars
+    const [_, folder, lib] = url.split("/");
+    if (folder === "javascripts") {
+      const version = PUBLIC_JS_VERSIONS[lib];
+      if (version) {
         return `${url}?v=${version}`;
       }
     }