From b9339e15a1f2f53e87e99d0e408bb829118be4f2 Mon Sep 17 00:00:00 2001
From: Bianca Nenciu <nenciu.bianca@gmail.com>
Date: Tue, 23 Apr 2019 23:13:23 +0300
Subject: [PATCH] FIX: Do not track a elements with no href.

---
 .../javascripts/discourse/lib/click-track.js.es6     | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/app/assets/javascripts/discourse/lib/click-track.js.es6 b/app/assets/javascripts/discourse/lib/click-track.js.es6
index 1143275386..52b1b7897f 100644
--- a/app/assets/javascripts/discourse/lib/click-track.js.es6
+++ b/app/assets/javascripts/discourse/lib/click-track.js.es6
@@ -10,7 +10,11 @@ export function isValidLink($link) {
   //  - links with disabled tracking
   //  - category links
   //  - quote back button
-  if ($link.is(".lightbox, .mention, .mention-group, .no-track-link, .hashtag, .back")) {
+  if (
+    $link.is(
+      ".lightbox, .mention, .mention-group, .no-track-link, .hashtag, .back"
+    )
+  ) {
     return false;
   }
 
@@ -63,10 +67,8 @@ export default {
       return true;
     }
 
-    let href = ($link.attr("href") || $link.data("href")).trim();
-    if (!href) {
-      return false;
-    } else if (href.indexOf("mailto:") === 0) {
+    let href = ($link.attr("href") || $link.data("href") || "").trim();
+    if (!href || href.indexOf("mailto:") === 0) {
       return true;
     }