From bb4d407b0d4e812367e3364f9f79ecd7c5c020ea Mon Sep 17 00:00:00 2001
From: Martin Brennan <martin@discourse.org>
Date: Thu, 23 Feb 2023 14:45:41 +1000
Subject: [PATCH] DEV: Add missing navigation_menu setting and simplify click
 in PO

---
 .../components/sidebar_header_dropdown.rb         | 15 +++------------
 spec/system/viewing_sidebar_mobile_spec.rb        |  7 +++++--
 2 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/spec/system/page_objects/components/sidebar_header_dropdown.rb b/spec/system/page_objects/components/sidebar_header_dropdown.rb
index 42ee72191a..247f5f9bbe 100644
--- a/spec/system/page_objects/components/sidebar_header_dropdown.rb
+++ b/spec/system/page_objects/components/sidebar_header_dropdown.rb
@@ -26,24 +26,15 @@ module PageObjects
       end
 
       def click_community_header_button
-        page.click_button(
-          I18n.t("js.sidebar.sections.community.header_action_title"),
-          class: "sidebar-section-header-button",
-        )
+        find(".sidebar-section-header-button").click
       end
 
       def click_everything_link
-        page.click_link(
-          I18n.t("js.sidebar.sections.community.links.everything.content"),
-          class: "sidebar-section-link-everything",
-        )
+        find(".sidebar-section-link-everything").click
       end
 
       def click_toggle_to_desktop_view_button
-        page.click_button(
-          I18n.t("js.desktop_view"),
-          class: "sidebar-footer-actions-toggle-mobile-view",
-        )
+        find(".sidebar-footer-actions-toggle-mobile-view").click
       end
     end
   end
diff --git a/spec/system/viewing_sidebar_mobile_spec.rb b/spec/system/viewing_sidebar_mobile_spec.rb
index 1f52bf5a48..196e566de6 100644
--- a/spec/system/viewing_sidebar_mobile_spec.rb
+++ b/spec/system/viewing_sidebar_mobile_spec.rb
@@ -5,7 +5,10 @@ describe "Viewing sidebar mobile", type: :system, js: true, mobile: true do
   let(:sidebar_dropdown) { PageObjects::Components::SidebarHeaderDropdown.new }
   let(:composer) { PageObjects::Components::Composer.new }
 
-  before { sign_in(user) }
+  before do
+    SiteSetting.navigation_menu = "sidebar"
+    sign_in(user)
+  end
 
   around do |example|
     original_disable_animation = Capybara.disable_animation
@@ -69,7 +72,7 @@ describe "Viewing sidebar mobile", type: :system, js: true, mobile: true do
     expect(sidebar_dropdown).to be_hidden
   end
 
-  it "toggles to desktop view after clicking on the toggle to desktop view button" do
+  it "toggles to desktop view after clicking on the toggle to desktop view button", mobile: true do
     visit ("/latest")
 
     expect(page).to have_css(".mobile-view")