From bb85795934000e6bb1c5f50809cbda8c2175db85 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Thu, 16 Mar 2017 11:33:55 +0800 Subject: [PATCH] FIX: Leave group membership button not updating. https://meta.discourse.org/t/leave-group-button-on-groups-page-doesnt-give-any-feedback/57359/4 --- .../discourse/components/group-membership-button.js.es6 | 2 +- .../components/group-membership-button-test.js.es6 | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/components/group-membership-button.js.es6 b/app/assets/javascripts/discourse/components/group-membership-button.js.es6 index a3de6d7ab0..83ad277df2 100644 --- a/app/assets/javascripts/discourse/components/group-membership-button.js.es6 +++ b/app/assets/javascripts/discourse/components/group-membership-button.js.es6 @@ -15,7 +15,7 @@ export default Ember.Component.extend({ @computed("model.is_group_user", "model.id", "groupUserIds") userIsGroupUser(isGroupUser, groupId, groupUserIds) { - if (isGroupUser) { + if (isGroupUser !== undefined) { return isGroupUser; } else { return !!groupUserIds && groupUserIds.includes(groupId); diff --git a/test/javascripts/components/group-membership-button-test.js.es6 b/test/javascripts/components/group-membership-button-test.js.es6 index b1796078d8..90831ec9c5 100644 --- a/test/javascripts/components/group-membership-button-test.js.es6 +++ b/test/javascripts/components/group-membership-button-test.js.es6 @@ -58,4 +58,11 @@ test('userIsGroupUser', function() { this.subject().set('groupUserIds', undefined); equal(this.subject().get('userIsGroupUser'), false); + + this.subject().setProperties({ + groupUserIds: [1, 3], + model: { id: 1, is_group_user: false } + }); + + equal(this.subject().get('userIsGroupUser'), false); });