From c13127b024db08ea510e2a73d2b19095f7adf349 Mon Sep 17 00:00:00 2001 From: Penar Musaraj Date: Tue, 21 Sep 2021 09:31:40 -0400 Subject: [PATCH] A11Y: Use listbox role for dropdowns (#14391) --- .../select-kit/addon/components/select-kit/select-kit-header.js | 2 +- .../addon/components/select-kit/single-select-header.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js b/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js index a5d504bb03..effe39459b 100644 --- a/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js +++ b/app/assets/javascripts/select-kit/addon/components/select-kit/select-kit-header.js @@ -18,7 +18,7 @@ export default Component.extend(UtilsMixin, { selectKit: null, - role: "application", + role: "listbox", ariaLevel: 1, diff --git a/app/assets/javascripts/select-kit/addon/components/select-kit/single-select-header.js b/app/assets/javascripts/select-kit/addon/components/select-kit/single-select-header.js index de669cd10b..8178544d75 100644 --- a/app/assets/javascripts/select-kit/addon/components/select-kit/single-select-header.js +++ b/app/assets/javascripts/select-kit/addon/components/select-kit/single-select-header.js @@ -8,7 +8,7 @@ export default SelectKitHeaderComponent.extend(UtilsMixin, { tagName: "summary", layout, classNames: ["single-select-header"], - attributeBindings: ["name"], + attributeBindings: ["name", "name:aria-label"], focusIn(event) { event.stopImmediatePropagation();