- {{plugin-outlet name="admin-customize-themes-show-top" args=(hash theme=model)}}
+ {{plugin-outlet name="admin-customize-themes-show-top" tagName="span" connectorTagName="div" args=(hash theme=model)}}
{{#if editingName}}
{{text-field value=model.name autofocus="true"}}
diff --git a/app/assets/javascripts/admin/addon/templates/dashboard.hbs b/app/assets/javascripts/admin/addon/templates/dashboard.hbs
index 07e1ab205d..e12e72dce6 100644
--- a/app/assets/javascripts/admin/addon/templates/dashboard.hbs
+++ b/app/assets/javascripts/admin/addon/templates/dashboard.hbs
@@ -1,4 +1,4 @@
-{{plugin-outlet name="admin-dashboard-top"}}
+{{plugin-outlet name="admin-dashboard-top" tagName="span" connectorTagName="div"}}
{{#if showVersionChecks}}
@@ -53,4 +53,4 @@
{{dashboard-new-features tagName="div"}}
-{{plugin-outlet name="admin-dashboard-bottom"}}
+{{plugin-outlet name="admin-dashboard-bottom" tagName="span" connectorTagName="div"}}
diff --git a/app/assets/javascripts/admin/addon/templates/dashboard_general.hbs b/app/assets/javascripts/admin/addon/templates/dashboard_general.hbs
index ec8f59eed6..4425ee338f 100644
--- a/app/assets/javascripts/admin/addon/templates/dashboard_general.hbs
+++ b/app/assets/javascripts/admin/addon/templates/dashboard_general.hbs
@@ -1,5 +1,5 @@
{{#conditional-loading-spinner condition=isLoading}}
- {{plugin-outlet name="admin-dashboard-general-top"}}
+ {{plugin-outlet name="admin-dashboard-general-top" tagName="span" connectorTagName="div"}}
{{#if isCommunityHealthVisible}}
- {{plugin-outlet name="admin-dashboard-general-bottom"}}
+ {{plugin-outlet name="admin-dashboard-general-bottom" tagName="span" connectorTagName="div"}}
{{/conditional-loading-spinner}}
diff --git a/app/assets/javascripts/admin/addon/templates/dashboard_moderation.hbs b/app/assets/javascripts/admin/addon/templates/dashboard_moderation.hbs
index f2191fbeec..cebed3c3ff 100644
--- a/app/assets/javascripts/admin/addon/templates/dashboard_moderation.hbs
+++ b/app/assets/javascripts/admin/addon/templates/dashboard_moderation.hbs
@@ -1,5 +1,5 @@
- {{plugin-outlet name="admin-dashboard-moderation-top"}}
+ {{plugin-outlet name="admin-dashboard-moderation-top" tagName="span" connectorTagName="div"}}
{{#if isModeratorsActivityVisible}}
@@ -40,6 +40,6 @@
filters=lastWeekfilters
reportOptions=userFlaggingRatioOptions}}
- {{plugin-outlet name="admin-dashboard-moderation-bottom"}}
+ {{plugin-outlet name="admin-dashboard-moderation-bottom" tagName="span" connectorTagName="div"}}
diff --git a/app/assets/javascripts/admin/addon/templates/dashboard_security.hbs b/app/assets/javascripts/admin/addon/templates/dashboard_security.hbs
index a42e65d58a..9f0a23dbb5 100644
--- a/app/assets/javascripts/admin/addon/templates/dashboard_security.hbs
+++ b/app/assets/javascripts/admin/addon/templates/dashboard_security.hbs
@@ -1,5 +1,5 @@
- {{plugin-outlet name="admin-dashboard-security-top"}}
+ {{plugin-outlet name="admin-dashboard-security-top" tagName="span" connectorTagName="div"}}
{{admin-report
@@ -10,6 +10,6 @@
dataSourceName="staff_logins"
filters=lastWeekfilters}}
- {{plugin-outlet name="admin-dashboard-security-bottom"}}
+ {{plugin-outlet name="admin-dashboard-security-bottom" tagName="span" connectorTagName="div"}}
diff --git a/app/assets/javascripts/admin/addon/templates/plugins-index.hbs b/app/assets/javascripts/admin/addon/templates/plugins-index.hbs
index d546540250..c2f0230898 100644
--- a/app/assets/javascripts/admin/addon/templates/plugins-index.hbs
+++ b/app/assets/javascripts/admin/addon/templates/plugins-index.hbs
@@ -67,4 +67,4 @@
{{i18n "admin.plugins.howto"}}
-{{plugin-outlet name="admin-below-plugins-index" args=(hash model=model)}}
+{{plugin-outlet name="admin-below-plugins-index" tagName="span" connectorTagName="div" args=(hash model=model)}}
diff --git a/app/assets/javascripts/admin/addon/templates/user-index.hbs b/app/assets/javascripts/admin/addon/templates/user-index.hbs
index df6c4c8406..ad93faf07d 100644
--- a/app/assets/javascripts/admin/addon/templates/user-index.hbs
+++ b/app/assets/javascripts/admin/addon/templates/user-index.hbs
@@ -27,8 +27,7 @@
{{plugin-outlet
name="admin-user-controls-after"
args=(hash model=model)
- tagName=""
- connectorTagName=""}}
+ }}
@@ -48,8 +47,7 @@
{{plugin-outlet
name="admin-user-below-names"
args=(hash user=model)
- tagName=""
- connectorTagName=""}}
+ }}
{{#if canCheckEmails}}
@@ -235,7 +233,7 @@
{{/if}}
-{{plugin-outlet name="admin-user-details" args=(hash model=model)}}
+{{plugin-outlet name="admin-user-details" tagName="span" connectorTagName="div" args=(hash model=model)}}
{{i18n "admin.user.permissions"}}
@@ -726,7 +724,7 @@
{{/if}}
-{{plugin-outlet name="after-user-details" args=(hash model=model)}}
+{{plugin-outlet name="after-user-details" tagName="span" connectorTagName="div" args=(hash model=model)}}
diff --git a/app/assets/javascripts/admin/addon/templates/users-list-show.hbs b/app/assets/javascripts/admin/addon/templates/users-list-show.hbs
index 605fc3edd1..a874252713 100644
--- a/app/assets/javascripts/admin/addon/templates/users-list-show.hbs
+++ b/app/assets/javascripts/admin/addon/templates/users-list-show.hbs
@@ -100,7 +100,7 @@
{{#if user.second_factor_enabled}}
{{d-icon "lock" title="admin.user.second_factor_enabled" }}
{{/if}}
- {{plugin-outlet name="admin-users-list-icon" tagName="" args=(hash user=user query=query)}}
+ {{plugin-outlet name="admin-users-list-icon" connectorTagName="div" args=(hash user=user query=query)}}
{{/each}}
diff --git a/app/assets/javascripts/admin/addon/templates/users-list.hbs b/app/assets/javascripts/admin/addon/templates/users-list.hbs
index 5f042993b3..88f860734a 100644
--- a/app/assets/javascripts/admin/addon/templates/users-list.hbs
+++ b/app/assets/javascripts/admin/addon/templates/users-list.hbs
@@ -8,7 +8,7 @@
{{nav-item route="adminUsersList.show" routeParam="silenced" label="admin.users.nav.silenced" class="silenced-users"}}
{{nav-item route="adminUsersList.show" routeParam="staged" label="admin.users.nav.staged" class="staged-users"}}
{{nav-item route="groups" label="groups.index.title" class="groups"}}
- {{plugin-outlet name="admin-users-list-nav-after" tagName="" connectorTagName=""}}
+ {{plugin-outlet name="admin-users-list-nav-after"}}
{{#if currentUser.can_invite_to_forum}}
diff --git a/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs b/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs
index 40a365f814..9cb7be2b72 100644
--- a/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs
+++ b/app/assets/javascripts/admin/addon/templates/web-hooks-show.hbs
@@ -71,7 +71,7 @@
- {{plugin-outlet name="web-hook-fields" args=(hash model=model)}}
+ {{plugin-outlet name="web-hook-fields" tagName="span" connectorTagName="div" args=(hash model=model)}}
{{input type="checkbox" name="verify_certificate" checked=model.verify_certificate}} {{i18n "admin.web_hooks.verify_certificate"}}
diff --git a/app/assets/javascripts/discourse/app/components/plugin-outlet.js b/app/assets/javascripts/discourse/app/components/plugin-outlet.js
index 410b070a1b..62a65832a1 100644
--- a/app/assets/javascripts/discourse/app/components/plugin-outlet.js
+++ b/app/assets/javascripts/discourse/app/components/plugin-outlet.js
@@ -36,16 +36,11 @@ import {
import Component from "@ember/component";
export default Component.extend({
- tagName: "span",
+ tagName: "",
+ connectorTagName: "",
connectors: null,
init() {
- // This should be the future default
- if (this.noTags) {
- this.set("tagName", "");
- this.set("connectorTagName", "");
- }
-
this._super(...arguments);
const name = this.name;
if (name) {
diff --git a/app/assets/javascripts/discourse/app/templates/about.hbs b/app/assets/javascripts/discourse/app/templates/about.hbs
index a9466b2b36..6dd8fc0db2 100644
--- a/app/assets/javascripts/discourse/app/templates/about.hbs
+++ b/app/assets/javascripts/discourse/app/templates/about.hbs
@@ -21,7 +21,6 @@
{{plugin-outlet name="about-after-description"
connectorTagName="section"
- tagName=""
args=(hash model=model)}}
{{#if model.admins}}
@@ -35,6 +34,7 @@
{{/if}}
{{plugin-outlet name="about-after-admins"
+ tagName="span"
connectorTagName="section"
args=(hash model=model)}}
@@ -50,6 +50,7 @@
{{/if}}
{{plugin-outlet name="about-after-moderators"
+ tagName="span"
connectorTagName="section"
args=(hash model=model)}}
diff --git a/app/assets/javascripts/discourse/app/templates/application.hbs b/app/assets/javascripts/discourse/app/templates/application.hbs
index d93102a917..b66122fdd3 100644
--- a/app/assets/javascripts/discourse/app/templates/application.hbs
+++ b/app/assets/javascripts/discourse/app/templates/application.hbs
@@ -1,7 +1,7 @@
{{#discourse-root}}
{{i18n "skip_to_main_content"}}
{{d-document}}
- {{plugin-outlet name="above-site-header" tagName=""}}
+ {{plugin-outlet name="above-site-header" connectorTagName="div"}}
{{site-header canSignUp=canSignUp
showCreateAccount=(route-action "showCreateAccount")
showLogin=(route-action "showLogin")
@@ -11,10 +11,10 @@
logout=(route-action "logout")}}
{{software-update-prompt}}
- {{plugin-outlet name="below-site-header" tagName="" args=(hash currentPath=router._router.currentPath)}}
+ {{plugin-outlet name="below-site-header" connectorTagName="div" args=(hash currentPath=router._router.currentPath)}}
- {{plugin-outlet name="above-main-container" tagName=""}}
+ {{plugin-outlet name="above-main-container" connectorTagName="div"}}
{{#if showTop}}
{{custom-html name="top"}}
@@ -23,17 +23,17 @@
{{pwa-install-banner}}
{{global-notice}}
{{create-topics-notice}}
- {{plugin-outlet name="top-notices" tagName="" args=(hash currentPath=router._router.currentPath)}}
+ {{plugin-outlet name="top-notices" connectorTagName="div" args=(hash currentPath=router._router.currentPath)}}
{{outlet}}
{{outlet "user-card"}}
- {{plugin-outlet name="above-footer" tagName="" args=(hash showFooter=showFooter)}}
+ {{plugin-outlet name="above-footer" connectorTagName="div" args=(hash showFooter=showFooter)}}
{{#if showFooter}}
{{custom-html name="footer" triggerAppEvent="true"}}
{{/if}}
- {{plugin-outlet name="below-footer" tagName="" args=(hash showFooter=showFooter)}}
+ {{plugin-outlet name="below-footer" connectorTagName="div" args=(hash showFooter=showFooter)}}
{{outlet "modal"}}
{{topic-entrance}}
diff --git a/app/assets/javascripts/discourse/app/templates/badges/index.hbs b/app/assets/javascripts/discourse/app/templates/badges/index.hbs
index 6ee39f7ff4..d680a99356 100644
--- a/app/assets/javascripts/discourse/app/templates/badges/index.hbs
+++ b/app/assets/javascripts/discourse/app/templates/badges/index.hbs
@@ -2,7 +2,7 @@
{{i18n "badges.title"}}
- {{plugin-outlet name="below-badges-title"}}
+ {{plugin-outlet name="below-badges-title" tagName="span" connectorTagName="div"}}
{{#each badgeGroups as |bg|}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs b/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs
index f59fa8155f..f34b9e21f2 100644
--- a/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/bread-crumbs.hbs
@@ -41,4 +41,4 @@
{{/if}}
{{/if}}
-{{plugin-outlet name="bread-crumbs-right" connectorTagName="li" tagName=""}}
+{{plugin-outlet name="bread-crumbs-right" connectorTagName="li"}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs
index 4b6ffd510d..9bd1f392fe 100644
--- a/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/categories-and-latest-topics.hbs
@@ -6,4 +6,4 @@
{{categories-topic-list topics=topics filter="latest" class="latest-topic-list"}}
-{{plugin-outlet name="extra-categories-column" tagName=""}}
+{{plugin-outlet name="extra-categories-column" connectorTagName="div"}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs
index 66cd56ff2e..803bd2dc8c 100644
--- a/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/categories-and-top-topics.hbs
@@ -6,4 +6,4 @@
{{categories-topic-list topics=topics filter="top" class="top-topic-list"}}
-{{plugin-outlet name="extra-categories-column" tagName=""}}
+{{plugin-outlet name="extra-categories-column" connectorTagName="div"}}
diff --git a/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs b/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs
index d9dcfa1a03..f11790e5c2 100644
--- a/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/categories-boxes-with-topics.hbs
@@ -35,7 +35,7 @@
{{/if}}
{{/unless}}
- {{plugin-outlet name="category-box-below-each-category" connectorTagName="" tagName="" args=(hash category=c)}}
+ {{plugin-outlet name="category-box-below-each-category" args=(hash category=c)}}